Added firestore rule&added ses client inside mail_service

Author: cp-nirali-s

firestore.rules

@@ -35,11 +35,11 @@ service cloud.firestore {
 
     // For Share Codes Collection
     match /shared_codes/{sharedCodeId} {
-    	allow read: if isAuthorized();
+        allow read: if isAuthorized();
 
-      allow create: if isUserPartOfGroup(request.resource.data.group_id);
+        allow create: if isUserPartOfGroup(request.resource.data.group_id);
 
-      allow delete: if isUserPartOfGroup(resource.data.group_id);
+        allow delete: if isUserPartOfGroup(resource.data.group_id);
     }
 
     // For Groups Collection
@@ -48,22 +48,22 @@ service cloud.firestore {
 
         allow create: if isAuthorized() && isCurrentUser(request.resource.data.created_by);
 
-        allow update: if isAuthorized() && (resource.data.members.hasAny([request.auth.uid]) ||
-                    	(!resource.data.members.hasAny([request.auth.uid]) &&
-request.resource.data.diff(resource.data).affectedKeys().hasOnly(["members"]))) 
-                        || request.resource.data.keys().hasAny(["updated_at", "updated_by"]
-                    );
+        allow update: if isAuthorized() &&
+                      (resource.data.members.hasAny([request.auth.uid]) ||
+                      (!resource.data.members.hasAny([request.auth.uid]) &&
+                      request.resource.data.diff(resource.data).affectedKeys().hasOnly(["members"]))) ||
+                      request.resource.data.keys().hasAny(["updated_at", "updated_by"]);
 
       allow delete: if isAuthorized() &&
-   		resource.data.members.hasAny([request.auth.uid]);
+                    resource.data.members.hasAny([request.auth.uid]);
     }
 
     // For Expenses Collection
     match /groups/{groupId}/expenses/{expenseId} {
       	allow read: if isAuthorized();
 
       	allow create: if isCurrentUser(request.resource.data.added_by) &&
-          				 		isUserPartOfGroup(groupId);
+                      isUserPartOfGroup(groupId);
 
         allow update: if isUserPartOfGroup(groupId);
 
@@ -72,7 +72,7 @@ request.resource.data.diff(resource.data).affectedKeys().hasOnly(["members"])))
 
     // For Transactions Collection
     match /groups/{groupId}/transactions/{transactionId} {
-      	allow read: if isAuthorized();
+        allow read: if isAuthorized();
 
       	allow create: if isUserPartOfGroup(groupId) &&
                       isMemberPartOfGroup(groupId, request.resource.data.payer_id) &&
@@ -85,15 +85,22 @@ request.resource.data.diff(resource.data).affectedKeys().hasOnly(["members"])))
       	allow delete: if isUserPartOfGroup(groupId);
     }
 
+    // For Feedback Collection
+    match /feedbacks/{feedbackId} {
+        allow create: if isAuthorized();
+      
+        allow read: if isAuthorized();
+    }
+        
     // Use for sub-collection as it'll not have parent's data
     function isUserPartOfGroup(groupId) {
     	let memberIds = get(/databases/$(database)/documents/groups/$(groupId)).data.members;
-      return isAuthorized() && memberIds.hasAny([request.auth.uid]);
+        return isAuthorized() && memberIds.hasAny([request.auth.uid]);
     }
 
     function isMemberPartOfGroup(groupId, memberId) {
     	let memberIds = get(/databases/$(database)/documents/groups/$(groupId)).data.members;
     	return isAuthorized() && memberIds.hasAny([memberId]);
     }
   }
-}
+}

functions/src/mail/mail_service.ts

@@ -3,24 +3,28 @@
 import { SendEmailCommand, SESClient } from "@aws-sdk/client-ses";
 require('dotenv').config()
 
-// Fetch AWS credentials securely from environment variable 
-const AWS_ACCESS_KEY_ID = process.env.AWS_ACCESS_KEY_ID;
-const AWS_SECRET_ACCESS_KEY = process.env.AWS_SECRET_ACCESS_KEY;
-const REGION = "ap-south-1";
+export class MailService {
+  private sesClient: SESClient;
 
-if (!AWS_ACCESS_KEY_ID || !AWS_SECRET_ACCESS_KEY) {
-  throw new Error('AWS credentials are missing');
-}
+  constructor() {
+    const AWS_ACCESS_KEY_ID = process.env.AWS_ACCESS_KEY_ID;
+    const AWS_SECRET_ACCESS_KEY = process.env.AWS_SECRET_ACCESS_KEY;
+    const REGION = "ap-south-1";
 
-const sesClient = new SESClient({
-  credentials: {
-    accessKeyId: AWS_ACCESS_KEY_ID,
-    secretAccessKey: AWS_SECRET_ACCESS_KEY,
-  },
-  region: REGION,
-});
+    // Check if the necessary credentials are present before initializing the client
+    if (!AWS_ACCESS_KEY_ID || !AWS_SECRET_ACCESS_KEY) {
+      throw new Error('AWS credentials are missing. Please provide AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY');
+    }
+
+    this.sesClient = new SESClient({
+      credentials: {
+        accessKeyId: AWS_ACCESS_KEY_ID,
+        secretAccessKey: AWS_SECRET_ACCESS_KEY,
+      },
+      region: REGION,
+    });
+  }
 
-export class MailService {
   private createSendEmailCommand(toAddresses: string[], fromAddress: string, subject: string, body: string): SendEmailCommand {
     return new SendEmailCommand({
       Destination: {
@@ -48,6 +52,6 @@ export class MailService {
 
   async sendEmail(to: string[], from: string, subject: string, body: string): Promise<void> {
     const mail = this.createSendEmailCommand(to, from, subject, body);
-    await sesClient.send(mail);
+    await this.sesClient.send(mail);
   }
 }