Skip to content

Commit 2304efc

Browse files
authored
switch kubernetes-extra image to version 1.0.2 (#16)
This PR updates the version of the [demo server image](https://github.com/canonical/api_demo_server/pkgs/container/api_demo_server) used in the `kubernetes-extra` charm. Version 1.0.2 fixes the bug where the returned version from the API is different from the image version.
1 parent 58046c4 commit 2304efc

4 files changed

Lines changed: 10 additions & 10 deletions

File tree

.implement/kubernetes-extra.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ def main():
99
r = rewriter.Rewriter('charmcraft.yaml')
1010
r.fwd(
1111
prefix=' upstream-source: some-repo/some-image:some-tag',
12-
change=' upstream-source: ghcr.io/canonical/api_demo_server:1.0.1',
12+
change=' upstream-source: ghcr.io/canonical/api_demo_server:1.0.2',
1313
)
1414
r.save()
1515

@@ -50,7 +50,7 @@ def main():
5050
change='# @pytest.mark.skip',
5151
)
5252
r.fwd(' assert version', remove_line=True)
53-
r.add(' assert version == "1.0.0" # (Bug) workload ought to return 1.0.1 instead.')
53+
r.add(' assert version == "1.0.2"')
5454
r.save()
5555

5656
# Format the charm code (just in case).

kubernetes-extra/charmcraft.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,4 +64,4 @@ resources:
6464
# used by the 'canonical/charming-actions' GitHub action for automated releases.
6565
# The test_deploy function in tests/integration/test_charm.py reads upstream-source
6666
# to determine which OCI image to use when running the charm's integration tests.
67-
upstream-source: ghcr.io/canonical/api_demo_server:1.0.1
67+
upstream-source: ghcr.io/canonical/api_demo_server:1.0.2

kubernetes-extra/tests/integration/test_charm.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,4 @@ def test_deploy(charm: pathlib.Path, juju: jubilant.Juju):
3131
def test_workload_version_is_set(charm: pathlib.Path, juju: jubilant.Juju):
3232
"""Check that the correct version of the workload is running."""
3333
version = juju.status().apps["my-application"].version
34-
assert version == "1.0.0" # (Bug) workload ought to return 1.0.1 instead.
34+
assert version == "1.0.2"

kubernetes-extra/uv.lock

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)