Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Custom ingress labels #2818

Open
kristeey opened this issue Jan 29, 2025 · 0 comments
Open

[ENHANCEMENT] Custom ingress labels #2818

kristeey opened this issue Jan 29, 2025 · 0 comments
Labels
kind/enhancement New feature or request

Comments

@kristeey
Copy link
Contributor

Describe the use case:

It would be nice to be able to add labels directly on specific Ingress resources. This is desirable in different usecases e.g. using label filtering with externalDNS in order to create DNS records based on ingresses with a specific label. Atm this is not possible without using the extraLabels attributes for some of the components (not all), but this will add the label on other resources as well.

Describe the enhancement/feature:

E.g. in the operate ingress:

{{- if and .Values.operate.enabled .Values.operate.ingress.enabled -}}
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: {{ include "operate.fullname" . }}
  labels:
    ...
    {{- if .Values.operate.ingress.labels }}
    {{ toYaml .Values.operate.ingress.labels  }}
    {{- end }}

Desired outcome and acceptance tests:

Ability to include specific labels for specific ingresses in the helm chart.

@kristeey kristeey added the kind/enhancement New feature or request label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant