Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feel Rule Reports False Positives #53

Open
philippfromme opened this issue Nov 2, 2022 · 1 comment
Open

feel Rule Reports False Positives #53

philippfromme opened this issue Nov 2, 2022 · 1 comment
Labels
backlog Queued in backlog bug Something isn't working

Comments

@philippfromme
Copy link
Collaborator

The feel rule matches any property that starts with = regardless of whether this property can be a FEEL expression.

<bpmn:serviceTask name="==5" />

will lead to a report that name is not a valid feel expression.

A possible solution could be adding metadata to the camunda-bpmn-moddle extension.

Example:

{
  "name": "InputOutputParameter",
  "properties": [
    {
      "name": "name",
      "isAttr": true,
      "type": "String"
    },
    {
      "name": "value",
      "isBody": true,
      "type": "String",
      "meta": {
        "feel": true
      }
    },
    {
      "name": "definition",
      "type": "InputOutputParameterDefinition"
    }
  ]
},

We'll have to investigate whether this works for all FEEL properties. Alternatively, we could have a list of properties that are supposed to be linted.

@barmac barmac added bug Something isn't working ready Ready to be worked on labels Nov 8, 2022
@CatalinaMoisuc
Copy link
Member

We can move this to backlog and it would come back if it is an issue after we've actually shipped https://github.com/camunda/product-hub/issues/280.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants