Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teaser borders inconsistencies #53

Open
thewilkybarkid opened this issue Oct 18, 2013 · 0 comments
Open

Teaser borders inconsistencies #53

thewilkybarkid opened this issue Oct 18, 2013 · 0 comments

Comments

@thewilkybarkid
Copy link
Contributor

There's conflicting guidance on the borders (if any) that should be applied to teasers.

The teaser component page has horizontal dividers inside a content container between rows of teasers, and nothing inbetween vertical teasers:

image

The section landing template has horizontal dividers not in a content container, and has vertical dividers between vertical teasers (but not touching the horizontal dividers):

image

www.cam.ac.uk goes for a third variant! (Horizontal divider inside a content container, and the vertical dividers touching.)

image

(You'll also notice the problem of the vertical border: it's applied on the right of the first column, but the second is longer in this case. For two columns both columns should have the border, but for more JavaScript would be required to make the heights equal.)

www.cam.ac.uk/about-the-university (for example) then has a 4th(!) variant on teasers on pages inside the site (horizontal not in a container, and the vertical divider not touching and in the wrong(?) place):

image

None of these variants resolve an issue on the mobile view however:

image

There is no horizontal divider between the vertical teasers. In this case they actually run in to each other too. A horizontal divider should be mimicked through CSS (failing that, added by JavaScript).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant