Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-d <alias> disables all instances of the pass invocation #985

Open
rachitnigam opened this issue Apr 25, 2022 · 1 comment
Open

-d <alias> disables all instances of the pass invocation #985

rachitnigam opened this issue Apr 25, 2022 · 1 comment
Labels
C: Calyx Extension or change to the Calyx IL S: Needs Triage Issue needs some thinking

Comments

@rachitnigam
Copy link
Contributor

An unintuitive problem that @paili0628 ran into for the #959 pass implementation is that the default pipeline now needs to call dead-group-removal twice. However, the -d <pass> option disables all instances the pass because it is excluded from the pass pipeline. The tests/passes/tdcc tests do -d post-opt which is an alias to -d dead-group-removal -d dead-cell-removal ... which hides the fact that the dead-group-removal pass is being implicitly disabled make the cause of the bug non-obvious.

We probably need to rethink the -d flag a little more and see if it makes sense. Long term, we probably need to re-design the pass manager.

@rachitnigam rachitnigam added C: Calyx Extension or change to the Calyx IL S: Needs Triage Issue needs some thinking labels Apr 25, 2022
@EclecticGriffin
Copy link
Collaborator

ahhh interesting and tricky! Maybe aliases should be more of a first class scheduling concept so disabling them is disabling a particular block in the main compilation chain rather than disabling each of its constituent passes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Calyx Extension or change to the Calyx IL S: Needs Triage Issue needs some thinking
Projects
None yet
Development

No branches or pull requests

2 participants