Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fud] Simplify and centralize fud configuration for Xilinx tools #856

Open
sampsyo opened this issue Jan 6, 2022 · 0 comments
Open

[fud] Simplify and centralize fud configuration for Xilinx tools #856

sampsyo opened this issue Jan 6, 2022 · 0 comments
Labels
C: FPGA Changes for the FPGA backend C: fud Calyx Driver S: Available Can be worked upon

Comments

@sampsyo
Copy link
Contributor

sampsyo commented Jan 6, 2022

There are several Xilinx-related stages in fud these days, and they all have different, overlapping sets of configuration options. In a spirit similar to #751's shared.data, we should centralize these in a xilinx section and remove duplication.

The current configuration options to be cleaned up are:

  • synth-verilog.exec: The Vivado executable. This is hard-coded elsewhere, such as in xclbin, and should not be.
  • wdb.{xilinx_location,xrt_location}: These are sort of redundant with synth-verilog.exec above. And these paths are also hard-coded in other locations.
  • {synth-verilog,xclbin,wdb}.{ssh_host,ssh_username,remote}: The optional SSH server details. You should only need to set these once. Also, I'm not sure why there is a separate remote option; I think SSH should probably just be enabled when ssh_host is defined.
  • xclbin.device: The FPGA device string. This is variously hard-coded in some places and ad-hoc shared by other stages.
  • xclbin.temp_location: This just doesn't seem very useful; we should probably just remove it.
  • fpga.data: Could be unified with other data options.
@sampsyo sampsyo added Priority: Low Don't do these during a deadline S: Available Can be worked upon C: fud Calyx Driver labels Jan 6, 2022
@sampsyo sampsyo added the C: FPGA Changes for the FPGA backend label Jul 15, 2022
This was referenced Jul 19, 2022
@rachitnigam rachitnigam removed the Priority: Low Don't do these during a deadline label Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: FPGA Changes for the FPGA backend C: fud Calyx Driver S: Available Can be worked upon
Projects
None yet
Development

No branches or pull requests

2 participants