-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run CIRCT Integration Tests in CI #1608
Comments
Heck yes! This is something we should definitely invest time in. The first step is figuring out if there a pre-built CIRCT/AMC docker we can pull in. If not, we can try setting it up using Depot which is what we use for the Calyx docker files. Once we have that, other things should be pretty straightforward! |
Good point about pulling in a pre-built Docker thing; that would make things a lot easier! Barring that, setting up this kind of testing as a nightly workflow (as opposed to the standard GitHub Actions "on every commit to |
Yeah this definitely seems like something that should be run nightly. I'm not sure there's anywhere that builds docker images for CIRCT with any regularity. Running nightly on the current heads of both CIRCT and Calyx seems like it would work out fine. |
@andrewb1999 since we've punted on the deadline, let's figure out how we can get this working sooner rather than later |
CIRCT binaries are now available as release artifacts: llvm/circt#5832. EDIT: Sorry, that PR only uploads the static libs for the binaries. We might need to do some more work to enable building of |
No, that PR uploads all binaries for both libraries and executables,
|
Oh, awesome! I'm glad to be wrong about this then! We can go ahead and start adding CIRCT to the CI for Calyx now |
We should work towards including the CIRCT frontend flow in CI for integration testing. This way we can know what changes to Calyx may affect the CIRCT frontend and also give us much more confidence in the quality of the CIRCT frontend. This will especially be useful since it will be much easier to create integration test cases than the CIRCT FileCheck test cases.
The text was updated successfully, but these errors were encountered: