Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating ports with name "primitive" leads to invalid verilog #1566

Open
UnsignedByte opened this issue Jun 11, 2023 · 2 comments
Open

Creating ports with name "primitive" leads to invalid verilog #1566

UnsignedByte opened this issue Jun 11, 2023 · 2 comments
Labels
C: Calyx Extension or change to the Calyx IL Type: Bug Bug in the implementation

Comments

@UnsignedByte
Copy link
Contributor

Just found this issue out with @rachitnigam; Ports can be named primitive which is a reserved verilog keyword, thus leading to verilog that does not compile.

@rachitnigam
Copy link
Contributor

rachitnigam commented Jun 11, 2023

We should add this to RESERVED_NAMES and make sure that port names go through the name generator.

@UnsignedByte
Copy link
Contributor Author

The same is true for the port name expect

@rachitnigam rachitnigam added Type: Bug Bug in the implementation C: Calyx Extension or change to the Calyx IL labels Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Calyx Extension or change to the Calyx IL Type: Bug Bug in the implementation
Projects
None yet
Development

No branches or pull requests

2 participants