Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ir::Builder::add_group() should take a done condition #1119

Open
calebmkim opened this issue Jul 20, 2022 · 1 comment
Open

ir::Builder::add_group() should take a done condition #1119

calebmkim opened this issue Jul 20, 2022 · 1 comment
Labels
C: Internal Changes to compiler internals good first issue Good issue to start contributing on Calyx S: Available Can be worked upon

Comments

@calebmkim
Copy link
Contributor

Since we know that every group must have a group[done] = ... assignment, the ir::Builder::add_group() function should take arguments for the group's done condition.

In fact, it may even be useful to have add_group() take a Vec<ir::Assignment> argument for the group's assignments, although there may be drawbacks to this that I'm not thinking of.
@rachitnigam rachitnigam added C: Calyx Extension or change to the Calyx IL S: Available Can be worked upon labels Jul 21, 2022
@rachitnigam
Copy link
Contributor

We should handle #864 when we fix this

@rachitnigam rachitnigam mentioned this issue Dec 28, 2022
Closed
3 tasks
@rachitnigam rachitnigam added C: Internal Changes to compiler internals and removed C: Calyx Extension or change to the Calyx IL labels May 8, 2023
@calebmkim calebmkim added the good first issue Good issue to start contributing on Calyx label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Internal Changes to compiler internals good first issue Good issue to start contributing on Calyx S: Available Can be worked upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Done conditions are distinguished calyxir/calyx
2 participants
@rachitnigam @calebmkim