Skip to content

Commit 9b231c1

Browse files
authored
Add Prettier to keep things consistent (#115)
* Add prettier * Run prettier:check on CI * Ran prettier:write * Add tsx to root package * Combine ignored patterns
1 parent 7424b4a commit 9b231c1

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+865
-430
lines changed

.github/workflows/check.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ jobs:
2626
node-version: lts/jod
2727
- run: npm ci
2828
- run: npm run lint
29+
- run: npm run prettier:check
2930
unit-tests:
3031
strategy:
3132
fail-fast: false

.prettierignore

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# Ignore artifacts
2+
dist
3+
build
4+
Pods
5+
target
6+
.cxx
7+
8+
# Ignore hermes
9+
packages/host/hermes
10+
packages/node-addon-examples/examples
11+
packages/node-tests/node
12+
packages/node-tests/tests
13+
packages/node-tests/*.generated.js

apps/test-app/App.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import { suites as nodeAddonExamplesSuites } from "@react-native-node-api/node-a
1313
function describeIf(
1414
condition: boolean,
1515
title: string,
16-
fn: (this: Mocha.Suite) => void
16+
fn: (this: Mocha.Suite) => void,
1717
) {
1818
return condition ? describe(title, fn) : describe.skip(title, fn);
1919
}
@@ -31,7 +31,7 @@ function loadTests({
3131
}: Context) {
3232
describeIf(nodeAddonExamples, "Node Addon Examples", () => {
3333
for (const [suiteName, examples] of Object.entries(
34-
nodeAddonExamplesSuites
34+
nodeAddonExamplesSuites,
3535
)) {
3636
describe(suiteName, () => {
3737
for (const [exampleName, requireExample] of Object.entries(examples)) {

apps/test-app/babel.config.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
module.exports = {
2-
presets: ['module:@react-native/babel-preset'],
2+
presets: ["module:@react-native/babel-preset"],
33
// plugins: [['module:react-native-node-api/babel-plugin', { stripPathSuffix: true }]],
4-
plugins: ['module:react-native-node-api/babel-plugin'],
4+
plugins: ["module:react-native-node-api/babel-plugin"],
55
};

apps/test-app/react-native.config.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
21
const project = (() => {
32
try {
43
const { configureProjects } = require("react-native-test-app");
@@ -25,4 +24,4 @@ const project = (() => {
2524

2625
module.exports = {
2726
...(project ? { project } : undefined),
28-
};
27+
};

docs/HOW-IT-WORKS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ The generated code looks something like this:
2525

2626
```javascript
2727
module.exports = require("react-native-node-api").requireNodeAddon(
28-
"calculator-lib--prebuild"
28+
"calculator-lib--prebuild",
2929
);
3030
```
3131

eslint.config.js

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,24 +2,27 @@
22

33
import { globalIgnores } from "eslint/config";
44
import globals from "globals";
5-
import eslint from '@eslint/js';
6-
import tseslint from 'typescript-eslint';
5+
import eslint from "@eslint/js";
6+
import tseslint from "typescript-eslint";
7+
import eslintConfigPrettier from "eslint-config-prettier/flat";
78

89
export default tseslint.config(
9-
globalIgnores([".nx/**"]),
10-
globalIgnores(["**/dist/**"]),
11-
globalIgnores(["apps/test-app/ios/**"]),
12-
globalIgnores(["packages/host/hermes/**"]),
13-
globalIgnores(["packages/node-addon-examples/examples/**"]),
14-
globalIgnores(["packages/ferric-example/ferric_example.d.ts"]),
10+
globalIgnores([
11+
"**/dist/**",
12+
"apps/test-app/ios/**",
13+
"packages/host/hermes/**",
14+
"packages/node-addon-examples/examples/**",
15+
"packages/ferric-example/ferric_example.d.ts",
16+
]),
1517
eslint.configs.recommended,
1618
tseslint.configs.recommended,
19+
eslintConfigPrettier,
1720
{
1821
files: [
1922
"apps/test-app/*.js",
2023
"packages/node-addon-examples/*.js",
2124
"packages/host/babel-plugin.js",
22-
"packages/host/react-native.config.js"
25+
"packages/host/react-native.config.js",
2326
],
2427
languageOptions: {
2528
parserOptions: {
@@ -38,7 +41,7 @@ export default tseslint.config(
3841
files: [
3942
"packages/gyp-to-cmake/bin/*.js",
4043
"packages/host/bin/*.mjs",
41-
"packages/host/scripts/*.mjs"
44+
"packages/host/scripts/*.mjs",
4245
],
4346
languageOptions: {
4447
globals: {

0 commit comments

Comments
 (0)