Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cffconvert causes conflicts with the latest JSON schema #2

Open
irm-codebase opened this issue Mar 13, 2025 · 0 comments
Open

cffconvert causes conflicts with the latest JSON schema #2

irm-codebase opened this issue Mar 13, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@irm-codebase
Copy link
Member

irm-codebase commented Mar 13, 2025

This issue was triggered by snakemake/snakemake#3299

The cffconvert dependency included in the template breaks snakemake compatibility with JSON schema 2020-12 (the latest one). That tool has not been updated in a while (and it may not be if CFF does not use any of the new features in JSON 2020-12).

This points towards moving all these documentation dependencies some place else.
Including the CFF file is still a good idea (it helps people cite the modules easily), but we should be careful on the amount of base dependencies we add going forward.

In combination with the documentation maintainability concerns raised by @sjpfenninger (here #1 (comment)), it is probably a better idea to check for existence of certain files during the integration test, and then use those to build documentation at https://clio.readthedocs.io/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant