Merge pull request #731 from cakephp/gc-fix

Revert "Use sub query instead of ids array."

Author: markstory

src/Model/Table/RequestsTable.php

@@ -75,6 +75,16 @@ public function findRecent(Query $query, array $options)
             ->limit(10);
     }
 
+    /**
+     * Check if garbage collection should be run
+     *
+     * @return bool
+     */
+    protected function shouldGc()
+    {
+        return time() % 100 === 0;
+    }
+
     /**
      * Garbage collect old request data.
      *
@@ -86,13 +96,16 @@ public function findRecent(Query $query, array $options)
      */
     public function gc()
     {
-        if (time() % 100 !== 0) {
+        if (!$this->shouldGc()) {
             return;
         }
         $noPurge = $this->find()
             ->select(['id'])
+            ->enableHydration(false)
             ->order(['requested_at' => 'desc'])
-            ->limit(Configure::read('DebugKit.requestCount') ?: 20);
+            ->limit(Configure::read('DebugKit.requestCount') ?: 20)
+            ->extract('id')
+            ->toArray();
 
         $query = $this->Panels->query()
             ->delete()

tests/TestCase/Model/Table/RequestTableTest.php

@@ -13,6 +13,7 @@
  */
 namespace DebugKit\Test\TestCase\Model\Table;
 
+use Cake\Core\Configure;
 use Cake\Database\Driver\Sqlite;
 use Cake\Datasource\ConnectionManager;
 use Cake\ORM\TableRegistry;
@@ -71,4 +72,35 @@ public function testFindRecent()
         $this->assertSame(10, $query->clause('limit'));
         $this->assertNotEmpty($query->clause('order'));
     }
+
+    /**
+     * Test the garbage collect.
+     *
+     * @return void
+     */
+    public function testGc()
+    {
+        /** @var \PHPUnit\Framework\MockObject\MockObject&\DebugKit\Model\Table\RequestsTable $requestsTableMock */
+        $requestsTableMock = $this->getMockForModel('DebugKit.Requests', ['shouldGc']);
+        $requestsTableMock->method('shouldGc')
+            ->will($this->returnValue(true));
+
+        $data = array_fill(0, 10, [
+            'url' => '/tasks/add',
+            'content_type' => 'text/html',
+            'status_code' => 200,
+            'requested_at' => '2014-08-21 7:41:12',
+        ]);
+        $requests = $requestsTableMock->newEntities($data);
+        $this->assertNotFalse($requestsTableMock->saveMany($requests));
+
+        $count = $requestsTableMock->find()->count();
+        $this->assertGreaterThanOrEqual(10, $count);
+
+        Configure::write('DebugKit.requestCount', 5);
+        $requestsTableMock->gc();
+
+        $count = $requestsTableMock->find()->count();
+        $this->assertSame(5, $count);
+    }
 }