Skip to content

Commit 9e5eaa6

Browse files
authored
Merge pull request #470 from gemal/master
minor fixes to unit test
2 parents 62edba7 + cbac8db commit 9e5eaa6

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

tests/TestCase/DebugMemoryTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,18 +62,18 @@ public function testMemorySettingAndGetting()
6262
$this->assertTrue($result);
6363

6464
$result = DebugMemory::getAll(true);
65-
$this->assertEquals(count($result), 1);
65+
$this->assertCount(1, $result);
6666
$this->assertTrue(isset($result['test marker']));
6767
$this->assertTrue(is_numeric($result['test marker']));
6868

6969
$result = DebugMemory::getAll();
70-
$this->assertTrue(empty($result));
70+
$this->assertEmpty($result);
7171

7272
DebugMemory::record('test marker');
7373
DebugMemory::record('test marker');
7474
$result = DebugMemory::getAll();
7575

76-
$this->assertEquals(count($result), 2);
76+
$this->assertCount(2, $result);
7777
$this->assertTrue(isset($result['test marker']));
7878
$this->assertTrue(isset($result['test marker #2']));
7979
}

tests/TestCase/DebugTimerTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public function testAnonymousTimers()
7070
$this->assertTrue(DebugTimer::stop());
7171
$timers = DebugTimer::getAll();
7272

73-
$this->assertEquals(2, count($timers));
73+
$this->assertCount(2, $timers);
7474
end($timers);
7575
$key = key($timers);
7676
$lineNo = __LINE__ - 8;
@@ -181,7 +181,7 @@ public function testGetTimers()
181181
DebugTimer::stop('test2');
182182
$timers = DebugTimer::getAll();
183183

184-
$this->assertEquals(3, count($timers));
184+
$this->assertCount(3, $timers);
185185
$this->assertTrue(is_float($timers['test1']['time']));
186186
$this->assertTrue(isset($timers['test1']['message']));
187187
$this->assertTrue(isset($timers['test2']['message']));

tests/TestCase/Model/Behavior/TimedBehaviorTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,15 +68,15 @@ public function tearDown()
6868
public function testFindTimers()
6969
{
7070
$timers = DebugTimer::getAll();
71-
$this->assertEquals(count($timers), 1);
71+
$this->assertCount(1, $timers);
7272

7373
$this->Article->find('all')->first();
7474
$result = DebugTimer::getAll();
75-
$this->assertEquals(count($result), 2);
75+
$this->assertCount(2, $result);
7676

7777
$this->Article->find('all')->first();
7878
$result = DebugTimer::getAll();
79-
$this->assertEquals(count($result), 3);
79+
$this->assertCount(3, $result);
8080
}
8181

8282
/**
@@ -87,11 +87,11 @@ public function testFindTimers()
8787
public function testSaveTimers()
8888
{
8989
$timers = DebugTimer::getAll();
90-
$this->assertEquals(count($timers), 1);
90+
$this->assertCount(1, $timers);
9191

9292
$article = $this->Article->newEntity(['user_id' => 1, 'title' => 'test', 'body' => 'test']);
9393
$this->Article->save($article);
9494
$result = DebugTimer::getAll();
95-
$this->assertEquals(count($result), 2);
95+
$this->assertCount(2, $result);
9696
}
9797
}

0 commit comments

Comments
 (0)