Merge pull request #1040 from cakephp/sqllog-panel

Add static API to add connections to the SqlPanel after initialization.

Author: markstory

src/Panel/SqlLogPanel.php

@@ -34,7 +34,7 @@ class SqlLogPanel extends DebugPanel
      *
      * @var array
      */
-    protected array $_loggers = [];
+    protected static array $_loggers = [];
 
     /**
      * Initialize hook - configures logger.
@@ -47,34 +47,47 @@ class SqlLogPanel extends DebugPanel
     public function initialize(): void
     {
         $configs = ConnectionManager::configured();
-        $includeSchemaReflection = (bool)Configure::read('DebugKit.includeSchemaReflection');
 
         foreach ($configs as $name) {
-            $connection = ConnectionManager::get($name);
-            if ($connection->configName() === 'debug_kit') {
-                continue;
-            }
-            $driver = $connection->getDriver();
-            $logger = null;
-            if ($driver instanceof Driver) {
-                $logger = $driver->getLogger();
-            } elseif (method_exists($connection, 'getLogger')) {
-                // ElasticSearch connection holds the logger, not the Elastica Driver
-                $logger = $connection->getLogger();
-            }
+            static::addConnection($name);
+        }
+    }
+
+    /**
+     * Add a connection to the list of loggers.
+     *
+     * @param string $name The name of the connection to add.
+     * @return void
+     */
+    public static function addConnection(string $name): void
+    {
+        $includeSchemaReflection = (bool)Configure::read('DebugKit.includeSchemaReflection');
 
-            if ($logger instanceof DebugLog) {
-                $logger->setIncludeSchema($includeSchemaReflection);
-                $this->_loggers[] = $logger;
-                continue;
-            }
-            $logger = new DebugLog($logger, $name, $includeSchemaReflection);
+        $connection = ConnectionManager::get($name);
+        if ($connection->configName() === 'debug_kit') {
+            return;
+        }
+        $driver = $connection->getDriver();
+        $logger = null;
+        if ($driver instanceof Driver) {
+            $logger = $driver->getLogger();
+        } elseif (method_exists($connection, 'getLogger')) {
+            // ElasticSearch connection holds the logger, not the Elastica Driver
+            $logger = $connection->getLogger();
+        }
 
-            /** @var \Cake\Database\Driver $driver */
-            $driver->setLogger($logger);
+        if ($logger instanceof DebugLog) {
+            $logger->setIncludeSchema($includeSchemaReflection);
+            static::$_loggers[] = $logger;
 
-            $this->_loggers[] = $logger;
+            return;
         }
+        $logger = new DebugLog($logger, $name, $includeSchemaReflection);
+
+        /** @var \Cake\Database\Driver $driver */
+        $driver->setLogger($logger);
+
+        static::$_loggers[] = $logger;
     }
 
     /**
@@ -88,7 +101,7 @@ public function data(): array
             'tables' => array_map(function (Table $table) {
                 return $table->getAlias();
             }, $this->getTableLocator()->genericInstances()),
-            'loggers' => $this->_loggers,
+            'loggers' => static::$_loggers,
         ];
     }
 
@@ -100,7 +113,7 @@ public function data(): array
     public function summary(): string
     {
         $count = $time = 0;
-        foreach ($this->_loggers as $logger) {
+        foreach (static::$_loggers as $logger) {
             $count += count($logger->queries());
             $time += $logger->totalTime();
         }