Merge pull request #852 from LordSimal/mark-duplicate-routes

highlight duplicate routes in routes panel

Author: markstory

templates/element/routes_panel.php

@@ -10,13 +10,19 @@
 
 $routes = Cake\Routing\Router::routes();
 
-$amountOfRoutesPerGroup = [];
+$amountOfRoutesPerGroup = $duplicateRoutes = [];
 foreach ($routes as $route) {
+    // Count the amount
     $group = $route->defaults['plugin'] ?? 'app';
     if (!array_key_exists($group, $amountOfRoutesPerGroup)) {
         $amountOfRoutesPerGroup[$group] = 0;
     }
     $amountOfRoutesPerGroup[$group]++;
+
+    if (!array_key_exists($route->template, $duplicateRoutes)) {
+        $duplicateRoutes[$route->template] = 0;
+    }
+    $duplicateRoutes[$route->template]++;
 }
 
 $pluginNames = [];
@@ -70,6 +76,11 @@
             $class .= ' highlighted';
         }
 
+        // Mark duplicate routes
+        if ($duplicateRoutes[$route->template] > 1) {
+            $class .= ' duplicate-route';
+        }
+
         ?>
         <tr class="<?= $class ?>">
             <td><?= h(Hash::get($route->options, '_name', $route->getName())) ?></td>

webroot/css/toolbar.css

@@ -270,6 +270,9 @@ pre,
 .debug-table td.left {
     text-align: left;
 }
+.debug-table .duplicate-route td {
+    background: #ffea96;
+}
 .debug-table .highlighted td {
   background: #e7e9fd;
 }
@@ -625,3 +628,24 @@ pre,
   flex-wrap: wrap;
   margin: 0 -5px;
 }
+
+.color-info-type {
+    align-items: center;
+    display: flex;
+}
+
+.color-info-type:before {
+    content: '';
+    display: inline-block;
+    height: 20px;
+    margin-right: 10px;
+    width: 20px;
+}
+
+.color-info-type--current-route:before {
+    background: #e7e9fd;
+}
+
+.color-info-type--duplicate-route:before {
+    background: #ffea96;
+}