Fix warnings when streaming HTML responses are used.

With the advent of streaming responses, some HTML responses will be
streamed. DebugKit can't realistically insert itself into these
streamed response bodies.

Refs #452

Author: markstory

src/Routing/Filter/DebugBarFilter.php

@@ -233,6 +233,9 @@ protected function _injectScripts($id, $response)
             return;
         }
         $body = $response->body();
+        if (!is_string($body)) {
+            return;
+        }
         $pos = strrpos($body, '</body>');
         if ($pos === false) {
             return;

tests/TestCase/Routing/Filter/DebugBarFilterTest.php

@@ -109,6 +109,31 @@ public function testAfterDispatchIgnoreRequestAction()
         $this->assertNotContains('<script>', $response->body());
     }
 
+    /**
+     * Test that afterDispatch ignores streaming bodies
+     *
+     * @return void
+     */
+    public function testAfterDispatchIgnoreStreamBodies()
+    {
+        $request = new Request([
+            'url' => '/articles',
+            'params' => ['plugin' => null]
+        ]);
+        $response = new Response([
+            'statusCode' => 200,
+            'type' => 'text/html',
+        ]);
+        $response->body(function() {
+            echo 'I am a teapot!';
+        });
+
+        $bar = new DebugBarFilter($this->events, []);
+        $event = new Event('Dispatcher.afterDispatch', $bar, compact('request', 'response'));
+        $this->assertNull($bar->afterDispatch($event));
+        $this->assertInstanceOf('Closure', $response->body());
+    }
+
     /**
      * Test that afterDispatch saves panel data.
      *