Skip to content

Commit 172b3f6

Browse files
author
David Porter
committed
Fix
Signed-off-by: David Porter <david.porter@uber.com>
1 parent 0e7302a commit 172b3f6

3 files changed

Lines changed: 51 additions & 49 deletions

File tree

common/persistence/execution_manager_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1441,6 +1441,7 @@ func sampleInternalWorkflowMutation() *InternalWorkflowMutation {
14411441
TimerID: "test-timer",
14421442
},
14431443
},
1444+
WorkflowTimerTasks: sampleEventData(),
14441445
UpsertChildExecutionInfos: []*InternalChildExecutionInfo{
14451446
{
14461447
DomainID: testDomainID,

service/history/execution/mutable_state_builder.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -324,6 +324,7 @@ func (e *mutableStateBuilder) CopyToPersistence() *persistence.WorkflowMutableSt
324324
state.Checksum = e.checksum
325325
state.ReplicationState = e.replicationState
326326
state.ExecutionStats = e.executionStats
327+
state.WorkflowTimerTaskInfos = e.workflowTimerTaskInfos
327328

328329
return state
329330
}

service/history/execution/mutable_state_builder_test.go

Lines changed: 49 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -3491,31 +3491,31 @@ func TestCloseTransactionAsMutation(t *testing.T) {
34913491
DecisionRequestID: commonconstants.EmptyUUID,
34923492
DecisionStartedID: commonconstants.EmptyEventID,
34933493
},
3494-
TasksByCategory: map[persistence.HistoryTaskCategory][]persistence.Task{
3495-
persistence.HistoryTaskCategoryTransfer: nil,
3496-
persistence.HistoryTaskCategoryTimer: nil,
3497-
persistence.HistoryTaskCategoryReplication: nil,
3498-
},
3499-
UpsertActivityInfos: []*persistence.ActivityInfo{},
3500-
DeleteActivityInfos: []int64{},
3501-
UpsertTimerInfos: []*persistence.TimerInfo{},
3502-
DeleteTimerInfos: []string{},
3503-
WorkflowTimerTasks: nil,
3504-
UpsertChildExecutionInfos: []*persistence.ChildExecutionInfo{},
3505-
UpsertRequestCancelInfos: []*persistence.RequestCancelInfo{},
3506-
DeleteRequestCancelInfos: []int64{},
3507-
UpsertSignalInfos: []*persistence.SignalInfo{},
3508-
DeleteSignalInfos: []int64{},
3509-
UpsertSignalRequestedIDs: []string{},
3510-
DeleteSignalRequestedIDs: []string{},
3511-
DeleteChildExecutionInfos: []int64{},
3512-
WorkflowRequests: []*persistence.WorkflowRequest{},
3513-
Condition: 0,
3514-
},
3515-
expectedEvent: nil,
3516-
expectedErr: nil,
3517-
},
3518-
"with buffered events": {
3494+
TasksByCategory: map[persistence.HistoryTaskCategory][]persistence.Task{
3495+
persistence.HistoryTaskCategoryTransfer: nil,
3496+
persistence.HistoryTaskCategoryTimer: nil,
3497+
persistence.HistoryTaskCategoryReplication: nil,
3498+
},
3499+
UpsertActivityInfos: []*persistence.ActivityInfo{},
3500+
DeleteActivityInfos: []int64{},
3501+
UpsertTimerInfos: []*persistence.TimerInfo{},
3502+
DeleteTimerInfos: []string{},
3503+
WorkflowTimerTasks: nil,
3504+
UpsertChildExecutionInfos: []*persistence.ChildExecutionInfo{},
3505+
UpsertRequestCancelInfos: []*persistence.RequestCancelInfo{},
3506+
DeleteRequestCancelInfos: []int64{},
3507+
UpsertSignalInfos: []*persistence.SignalInfo{},
3508+
DeleteSignalInfos: []int64{},
3509+
UpsertSignalRequestedIDs: []string{},
3510+
DeleteSignalRequestedIDs: []string{},
3511+
DeleteChildExecutionInfos: []int64{},
3512+
WorkflowRequests: []*persistence.WorkflowRequest{},
3513+
Condition: 0,
3514+
},
3515+
expectedEvent: nil,
3516+
expectedErr: nil,
3517+
},
3518+
"with buffered events": {
35193519
mutableStateSetup: func(ms *mutableStateBuilder) {
35203520
ms.executionInfo.DomainID = "some-domain-id"
35213521
ms.executionInfo.NextEventID = 10
@@ -3580,33 +3580,33 @@ func TestCloseTransactionAsMutation(t *testing.T) {
35803580
},
35813581
},
35823582
},
3583-
UpsertActivityInfos: []*persistence.ActivityInfo{},
3584-
DeleteActivityInfos: []int64{},
3585-
UpsertTimerInfos: []*persistence.TimerInfo{},
3586-
DeleteTimerInfos: []string{},
3587-
WorkflowTimerTasks: nil,
3588-
UpsertChildExecutionInfos: []*persistence.ChildExecutionInfo{},
3589-
UpsertRequestCancelInfos: []*persistence.RequestCancelInfo{},
3590-
DeleteRequestCancelInfos: []int64{},
3591-
UpsertSignalInfos: []*persistence.SignalInfo{},
3592-
DeleteSignalInfos: []int64{},
3593-
UpsertSignalRequestedIDs: []string{},
3594-
DeleteSignalRequestedIDs: []string{},
3595-
DeleteChildExecutionInfos: []int64{},
3596-
WorkflowRequests: []*persistence.WorkflowRequest{},
3597-
Condition: 0,
3598-
},
3599-
expectedEvent: []*persistence.WorkflowEvents{
3600-
{
3601-
DomainID: "some-domain-id",
3602-
Events: []*types.HistoryEvent{{
3603-
ID: 1, EventType: types.EventTypeWorkflowExecutionStarted.Ptr()},
3583+
UpsertActivityInfos: []*persistence.ActivityInfo{},
3584+
DeleteActivityInfos: []int64{},
3585+
UpsertTimerInfos: []*persistence.TimerInfo{},
3586+
DeleteTimerInfos: []string{},
3587+
WorkflowTimerTasks: nil,
3588+
UpsertChildExecutionInfos: []*persistence.ChildExecutionInfo{},
3589+
UpsertRequestCancelInfos: []*persistence.RequestCancelInfo{},
3590+
DeleteRequestCancelInfos: []int64{},
3591+
UpsertSignalInfos: []*persistence.SignalInfo{},
3592+
DeleteSignalInfos: []int64{},
3593+
UpsertSignalRequestedIDs: []string{},
3594+
DeleteSignalRequestedIDs: []string{},
3595+
DeleteChildExecutionInfos: []int64{},
3596+
WorkflowRequests: []*persistence.WorkflowRequest{},
3597+
Condition: 0,
3598+
},
3599+
expectedEvent: []*persistence.WorkflowEvents{
3600+
{
3601+
DomainID: "some-domain-id",
3602+
Events: []*types.HistoryEvent{{
3603+
ID: 1, EventType: types.EventTypeWorkflowExecutionStarted.Ptr()},
3604+
},
36043605
},
36053606
},
3607+
expectedErr: nil,
36063608
},
3607-
expectedErr: nil,
3608-
},
3609-
}
3609+
}
36103610

36113611
for name, td := range tests {
36123612

0 commit comments

Comments
 (0)