From 9ea72a9071f5e8e28a91d9821c3a759b7c397515 Mon Sep 17 00:00:00 2001
From: hobostay <110hqc@gmail.com>
Date: Fri, 6 Feb 2026 19:46:19 +0800
Subject: [PATCH] fix: improve type safety in legacy config migration

- Add None check for top_k with default value fallback
- Extract provider_config variable to reduce code duplication
- Improve code readability and maintainability

This prevents potential type errors when migrating from legacy JSON configs
and makes the code more defensive against edge cases.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
---
 trae_agent/utils/config.py | 26 +++++++++++---------------
 1 file changed, 11 insertions(+), 15 deletions(-)

diff --git a/trae_agent/utils/config.py b/trae_agent/utils/config.py
index d9502690..caafe7c5 100644
--- a/trae_agent/utils/config.py
+++ b/trae_agent/utils/config.py
@@ -343,23 +343,19 @@ def create_from_legacy_config(
             provider=legacy_config.default_provider,
         )
 
+        provider_config = legacy_config.model_providers[legacy_config.default_provider]
+
         model_config = ModelConfig(
-            model=legacy_config.model_providers[legacy_config.default_provider].model,
+            model=provider_config.model,
             model_provider=model_provider,
-            max_tokens=legacy_config.model_providers[legacy_config.default_provider].max_tokens,
-            temperature=legacy_config.model_providers[legacy_config.default_provider].temperature,
-            top_p=legacy_config.model_providers[legacy_config.default_provider].top_p,
-            top_k=legacy_config.model_providers[legacy_config.default_provider].top_k,
-            parallel_tool_calls=legacy_config.model_providers[
-                legacy_config.default_provider
-            ].parallel_tool_calls,
-            max_retries=legacy_config.model_providers[legacy_config.default_provider].max_retries,
-            candidate_count=legacy_config.model_providers[
-                legacy_config.default_provider
-            ].candidate_count,
-            stop_sequences=legacy_config.model_providers[
-                legacy_config.default_provider
-            ].stop_sequences,
+            max_tokens=provider_config.max_tokens,
+            temperature=provider_config.temperature,
+            top_p=provider_config.top_p,
+            top_k=provider_config.top_k if provider_config.top_k is not None else 0,
+            parallel_tool_calls=provider_config.parallel_tool_calls,
+            max_retries=provider_config.max_retries,
+            candidate_count=provider_config.candidate_count,
+            stop_sequences=provider_config.stop_sequences,
         )
         mcp_servers_config = {
             k: MCPServerConfig(**vars(v)) for k, v in legacy_config.mcp_servers.items()