feat: support pretty() no-op and Int32 string args (BYT-9080)

Fix 2 mongosh compatibility issues that caused unnecessary fallbacks:
- pretty(): treat as no-op cursor method (output already formatted)
- Int32("string")/NumberInt("string"): accept string arguments in parser

Deprecated methods (insert, count, update) intentionally left as
unsupported to keep gomongo simple — they fall back to mongosh.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: h3n4l

compat_test.go

@@ -47,130 +47,6 @@ func TestPrettyNoOp(t *testing.T) {
 	})
 }
 
-func TestDeprecatedInsert(t *testing.T) {
-	testutil.RunOnAllDBs(t, func(t *testing.T, db testutil.TestDB) {
-		dbName := fmt.Sprintf("testdb_insert_%s", db.Name)
-		defer testutil.CleanupDatabase(t, db.Client, dbName)
-
-		ctx := context.Background()
-		gc := gomongo.NewClient(db.Client)
-
-		// insert() with a single document should behave like insertOne()
-		result, err := gc.Execute(ctx, dbName, `db.users.insert({name: "alice", age: 30})`)
-		require.NoError(t, err)
-		require.NotNil(t, result)
-
-		// Verify the document was inserted
-		result, err = gc.Execute(ctx, dbName, `db.users.find({name: "alice"})`)
-		require.NoError(t, err)
-		require.Equal(t, 1, len(result.Value))
-
-		// insert() with an array should behave like insertMany()
-		result, err = gc.Execute(ctx, dbName, `db.users.insert([{name: "bob"}, {name: "charlie"}])`)
-		require.NoError(t, err)
-		require.NotNil(t, result)
-
-		// Verify all documents
-		result, err = gc.Execute(ctx, dbName, `db.users.find()`)
-		require.NoError(t, err)
-		require.Equal(t, 3, len(result.Value))
-
-		// insert() via getCollection
-		result, err = gc.Execute(ctx, dbName, `db.getCollection("users").insert({name: "dave"})`)
-		require.NoError(t, err)
-		require.NotNil(t, result)
-
-		result, err = gc.Execute(ctx, dbName, `db.users.find()`)
-		require.NoError(t, err)
-		require.Equal(t, 4, len(result.Value))
-	})
-}
-
-func TestDeprecatedCount(t *testing.T) {
-	testutil.RunOnAllDBs(t, func(t *testing.T, db testutil.TestDB) {
-		dbName := fmt.Sprintf("testdb_count_%s", db.Name)
-		defer testutil.CleanupDatabase(t, db.Client, dbName)
-
-		ctx := context.Background()
-		collection := db.Client.Database(dbName).Collection("items")
-		_, err := collection.InsertMany(ctx, []any{
-			bson.M{"name": "a", "status": "active"},
-			bson.M{"name": "b", "status": "active"},
-			bson.M{"name": "c", "status": "inactive"},
-		})
-		require.NoError(t, err)
-
-		gc := gomongo.NewClient(db.Client)
-
-		// count() with no args should return total count
-		result, err := gc.Execute(ctx, dbName, `db.items.count()`)
-		require.NoError(t, err)
-		require.Equal(t, 1, len(result.Value))
-		require.Equal(t, int64(3), result.Value[0])
-
-		// count({}) with empty filter
-		result, err = gc.Execute(ctx, dbName, `db.items.count({})`)
-		require.NoError(t, err)
-		require.Equal(t, 1, len(result.Value))
-		require.Equal(t, int64(3), result.Value[0])
-
-		// count() with filter
-		result, err = gc.Execute(ctx, dbName, `db.items.count({status: "active"})`)
-		require.NoError(t, err)
-		require.Equal(t, 1, len(result.Value))
-		require.Equal(t, int64(2), result.Value[0])
-	})
-}
-
-func TestDeprecatedUpdate(t *testing.T) {
-	testutil.RunOnAllDBs(t, func(t *testing.T, db testutil.TestDB) {
-		dbName := fmt.Sprintf("testdb_update_%s", db.Name)
-		defer testutil.CleanupDatabase(t, db.Client, dbName)
-
-		ctx := context.Background()
-		collection := db.Client.Database(dbName).Collection("users")
-		_, err := collection.InsertMany(ctx, []any{
-			bson.M{"name": "alice", "age": 30},
-			bson.M{"name": "bob", "age": 25},
-		})
-		require.NoError(t, err)
-
-		gc := gomongo.NewClient(db.Client)
-
-		// update() defaults to updateOne behavior
-		result, err := gc.Execute(ctx, dbName, `db.users.update({name: "alice"}, {$set: {age: 31}})`)
-		require.NoError(t, err)
-		require.NotNil(t, result)
-
-		// Verify the update
-		findResult, err := gc.Execute(ctx, dbName, `db.users.findOne({name: "alice"})`)
-		require.NoError(t, err)
-		require.Equal(t, 1, len(findResult.Value))
-		require.Contains(t, valueToJSON(findResult.Value[0]), `31`)
-
-		// update() with multi: true should behave like updateMany
-		_, err = collection.InsertOne(ctx, bson.M{"name": "alice", "age": 20})
-		require.NoError(t, err)
-
-		result, err = gc.Execute(ctx, dbName, `db.users.update({name: "alice"}, {$set: {age: 99}}, {multi: true})`)
-		require.NoError(t, err)
-		require.NotNil(t, result)
-
-		// Verify both alices were updated
-		findResult, err = gc.Execute(ctx, dbName, `db.users.find({name: "alice"})`)
-		require.NoError(t, err)
-		require.Equal(t, 2, len(findResult.Value))
-		for _, v := range findResult.Value {
-			require.Contains(t, valueToJSON(v), `99`)
-		}
-
-		// update() via getCollection
-		result, err = gc.Execute(ctx, dbName, `db.getCollection("users").update({name: "bob"}, {$set: {age: 26}})`)
-		require.NoError(t, err)
-		require.NotNil(t, result)
-	})
-}
-
 func TestInt32StringArg(t *testing.T) {
 	testutil.RunOnAllDBs(t, func(t *testing.T, db testutil.TestDB) {
 		dbName := fmt.Sprintf("testdb_int32str_%s", db.Name)

internal/translator/collection.go

@@ -4,7 +4,6 @@ import (
 	"fmt"
 	"strconv"
 
-	"github.com/bytebase/gomongo/types"
 	"github.com/bytebase/parser/mongodb"
 	"go.mongodb.org/mongo-driver/v2/bson"
 )
@@ -2227,208 +2226,3 @@ func (v *visitor) extractCreateIndexesArgs(ctx mongodb.ICreateIndexesMethodConte
 	}
 }
 
-// extractDeprecatedInsertArgs handles the deprecated insert() method.
-// insert(doc) → insertOne, insert([doc1, doc2]) → insertMany.
-func (v *visitor) extractDeprecatedInsertArgs(ctx mongodb.ICollectionInsertMethodContext) {
-	method, ok := ctx.(*mongodb.CollectionInsertMethodContext)
-	if !ok {
-		return
-	}
-
-	args := method.Arguments()
-	if args == nil {
-		v.err = fmt.Errorf("insert() requires a document or array argument")
-		return
-	}
-
-	argsCtx, ok := args.(*mongodb.ArgumentsContext)
-	if !ok {
-		v.err = fmt.Errorf("insert() requires a document or array argument")
-		return
-	}
-
-	allArgs := argsCtx.AllArgument()
-	if len(allArgs) == 0 {
-		v.err = fmt.Errorf("insert() requires a document or array argument")
-		return
-	}
-
-	firstArg, ok := allArgs[0].(*mongodb.ArgumentContext)
-	if !ok {
-		v.err = fmt.Errorf("insert() requires a document or array argument")
-		return
-	}
-
-	valueCtx := firstArg.Value()
-	if valueCtx == nil {
-		v.err = fmt.Errorf("insert() requires a document or array argument")
-		return
-	}
-
-	switch val := valueCtx.(type) {
-	case *mongodb.DocumentValueContext:
-		// Single document → insertOne
-		v.operation.OpType = types.OpInsertOne
-		doc, err := convertDocument(val.Document())
-		if err != nil {
-			v.err = fmt.Errorf("invalid document: %w", err)
-			return
-		}
-		v.operation.Document = doc
-	case *mongodb.ArrayValueContext:
-		// Array of documents → insertMany
-		v.operation.OpType = types.OpInsertMany
-		arr, err := convertArray(val.Array())
-		if err != nil {
-			v.err = fmt.Errorf("invalid documents array: %w", err)
-			return
-		}
-		var docs []bson.D
-		for i, elem := range arr {
-			doc, ok := elem.(bson.D)
-			if !ok {
-				v.err = fmt.Errorf("insert() element %d must be a document", i)
-				return
-			}
-			docs = append(docs, doc)
-		}
-		v.operation.Documents = docs
-	default:
-		v.err = fmt.Errorf("insert() argument must be a document or array")
-		return
-	}
-}
-
-// extractDeprecatedCountArgs handles the deprecated count() collection method.
-// count(filter?) → countDocuments(filter?).
-func (v *visitor) extractDeprecatedCountArgs(ctx mongodb.ICollectionCountMethodContext) {
-	method, ok := ctx.(*mongodb.CollectionCountMethodContext)
-	if !ok {
-		return
-	}
-	v.extractArgumentsForCountDocuments(method.Arguments())
-}
-
-// extractDeprecatedUpdateArgs handles the deprecated update() method.
-// update(filter, update, options?) — options.multi determines updateOne vs updateMany.
-func (v *visitor) extractDeprecatedUpdateArgs(ctx mongodb.IUpdateMethodContext) {
-	method, ok := ctx.(*mongodb.UpdateMethodContext)
-	if !ok {
-		return
-	}
-
-	args := method.Arguments()
-	if args == nil {
-		v.err = fmt.Errorf("update() requires filter and update arguments")
-		return
-	}
-
-	argsCtx, ok := args.(*mongodb.ArgumentsContext)
-	if !ok {
-		v.err = fmt.Errorf("update() requires filter and update arguments")
-		return
-	}
-
-	allArgs := argsCtx.AllArgument()
-	if len(allArgs) < 2 {
-		v.err = fmt.Errorf("update() requires filter and update arguments")
-		return
-	}
-
-	// Default to updateOne; check for multi option later.
-	v.operation.OpType = types.OpUpdateOne
-
-	// First argument: filter
-	firstArg, ok := allArgs[0].(*mongodb.ArgumentContext)
-	if !ok {
-		v.err = fmt.Errorf("update() filter must be a document")
-		return
-	}
-	filterValueCtx := firstArg.Value()
-	if filterValueCtx == nil {
-		v.err = fmt.Errorf("update() filter must be a document")
-		return
-	}
-	filterDocValue, ok := filterValueCtx.(*mongodb.DocumentValueContext)
-	if !ok {
-		v.err = fmt.Errorf("update() filter must be a document")
-		return
-	}
-	filter, err := convertDocument(filterDocValue.Document())
-	if err != nil {
-		v.err = fmt.Errorf("invalid filter: %w", err)
-		return
-	}
-	v.operation.Filter = filter
-
-	// Second argument: update
-	secondArg, ok := allArgs[1].(*mongodb.ArgumentContext)
-	if !ok {
-		v.err = fmt.Errorf("update() update must be a document or array")
-		return
-	}
-	updateValueCtx := secondArg.Value()
-	if updateValueCtx == nil {
-		v.err = fmt.Errorf("update() update must be a document or array")
-		return
-	}
-	switch uv := updateValueCtx.(type) {
-	case *mongodb.DocumentValueContext:
-		update, err := convertDocument(uv.Document())
-		if err != nil {
-			v.err = fmt.Errorf("invalid update: %w", err)
-			return
-		}
-		v.operation.Update = update
-	case *mongodb.ArrayValueContext:
-		pipeline, err := convertArray(uv.Array())
-		if err != nil {
-			v.err = fmt.Errorf("invalid update pipeline: %w", err)
-			return
-		}
-		v.operation.Update = pipeline
-	default:
-		v.err = fmt.Errorf("update() update must be a document or array")
-		return
-	}
-
-	// Third argument: options (optional)
-	if len(allArgs) >= 3 {
-		thirdArg, ok := allArgs[2].(*mongodb.ArgumentContext)
-		if !ok {
-			return
-		}
-		optionsValueCtx := thirdArg.Value()
-		if optionsValueCtx == nil {
-			return
-		}
-		optionsDocValue, ok := optionsValueCtx.(*mongodb.DocumentValueContext)
-		if !ok {
-			v.err = fmt.Errorf("update() options must be a document")
-			return
-		}
-		options, err := convertDocument(optionsDocValue.Document())
-		if err != nil {
-			v.err = fmt.Errorf("invalid options: %w", err)
-			return
-		}
-		for _, opt := range options {
-			switch opt.Key {
-			case "multi":
-				if val, ok := opt.Value.(bool); ok && val {
-					v.operation.OpType = types.OpUpdateMany
-				}
-			case "upsert":
-				if val, ok := opt.Value.(bool); ok {
-					v.operation.Upsert = &val
-				}
-			default:
-				v.err = &UnsupportedOptionError{
-					Method: "update()",
-					Option: opt.Key,
-				}
-				return
-			}
-		}
-	}
-}

internal/translator/visitor.go

@@ -234,15 +234,6 @@ func (v *visitor) visitCollectionMethodCall(ctx mongodb.ICollectionMethodCallCon
 		v.operation.OpType = types.OpRenameCollection
 		v.extractRenameCollectionArgs(mc.RenameCollectionMethod())
 
-	// Deprecated methods (translated to modern equivalents)
-	case mc.CollectionInsertMethod() != nil:
-		v.extractDeprecatedInsertArgs(mc.CollectionInsertMethod())
-	case mc.CollectionCountMethod() != nil:
-		v.operation.OpType = types.OpCountDocuments
-		v.extractDeprecatedCountArgs(mc.CollectionCountMethod())
-	case mc.UpdateMethod() != nil:
-		v.extractDeprecatedUpdateArgs(mc.UpdateMethod())
-
 	// Collection information commands
 	case mc.StatsMethod() != nil:
 		v.operation.OpType = types.OpCollectionStats