Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple login prompts show up when login button is clicked more than once #57

Open
2 tasks
by12380 opened this issue Sep 10, 2018 · 0 comments
Open
2 tasks
Labels
bug Something isn't working Electron Expo

Comments

@by12380
Copy link
Owner

by12380 commented Sep 10, 2018

In both the Expo and Electron project, when the login button is clicked the second time during a slight delay before the first login prompt pops-up from the first click, it triggers and shows two login prompt in the end. (Expo app explicitly gives warning)

Potential fix:

Perhaps disable the login button right after the first click and enable button again after the login prompt exits (whether the user successfully logs in or quits login prompt).

Or

A loading overlay page that prevents user from clicking any buttons while the login proccess is in progress.

Suggesstion: Use loginPending redux state to enable and disable the loading feature.

Fixed issue for:

  • Electron
  • Expo
@by12380 by12380 added bug Something isn't working Electron Expo labels Sep 10, 2018
@by12380 by12380 changed the title Multiple login prompt shows up when login button is clicked more than once Multiple login prompts show up when login button is clicked more than once Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Electron Expo
Projects
None yet
Development

No branches or pull requests

1 participant