Skip to content

Commit bf9e944

Browse files
Apply suggestions from code review.
Co-authored-by: Matthew McNew <me@mattmcnew.com>
1 parent 571a365 commit bf9e944

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

rfcs/0000-cosign-integration.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ signatures to a registry so that users can ensure the chain of custody of a
3333
generated artifact.
3434

3535
This proposal aims to cover specifically the flow of signing an image produced
36-
by the `kpack Image` resource, along with its builder image, without
36+
by the kpack `Image`, `Build`, `Builder` and `ClusterBuilder` resources, without
3737
verification of any container images pulled in the process.
3838

3939
## Actions to take
@@ -44,7 +44,7 @@ verification of any container images pulled in the process.
4444
calculates its signature and pushes it either to the registry where the image
4545
is located, using the same credentials that were used to push the image, or
4646
[to the registry specified in the `COSIGN_REPOSITORY` environment variable](#key-generation-and-storage).
47-
`kpack` should sign both the user-requested image being generated and the
47+
`kpack` should sign images produced by kpack builds and images produced by the Builder and ClusterBuilder resources, using their respective service accounts to
4848
builder image used for the build, using their respective service accounts to
4949
find credentials. This flow must happen after each of the images have been
5050
pushed to the registry.
@@ -53,8 +53,8 @@ verification of any container images pulled in the process.
5353
message in the build log, so the operator can troubleshoot the issue. The
5454
error messages should also be added in any other places where error messages
5555
are presented.
56-
57-
- Whenever `kpack` signs an image using `cosign`, it should add these
56+
- If `cosign` fails to sign an image produced by a Builder resource the Builder should not enter a Ready status.
57+
- Whenever `kpack` signs an image produced within a kpack build using `cosign`, it should add these
5858
annotations:
5959
- Build number.
6060
- Build time.

0 commit comments

Comments
 (0)