From 01f8d9f5f2a1e658b2dfb5f5034e950de0f6934a Mon Sep 17 00:00:00 2001
From: Vladimir Panteleev <git@thecybershadow.net>
Date: Fri, 9 Oct 2020 04:03:36 +0000
Subject: [PATCH] Remove BMO favicon from top-level static directory

The route was added in the initial Mojolicious translation in
b8b2a943056adbb112474df7bdf766970a56b2dc. However, it was apparently
insufficient as a copy of the favicon had been added to the top-level
public directory in 2bee49bad080aede10ced49731bb679af265ecbb.

This commit removes the default Mojolicious favicon static rule, as
documented on https://docs.mojolicious.org/Mojolicious/Static#extra ,
which fixes the routing rule in BMO/Extension.pm, and allows us to
remove the redundant copy from public/.
---
 extensions/BMO/Extension.pm |   1 +
 public/favicon.ico          | Bin 1150 -> 0 bytes
 2 files changed, 1 insertion(+)
 delete mode 100644 public/favicon.ico

diff --git a/extensions/BMO/Extension.pm b/extensions/BMO/Extension.pm
index c46438f99d..418998da74 100644
--- a/extensions/BMO/Extension.pm
+++ b/extensions/BMO/Extension.pm
@@ -2786,6 +2786,7 @@ sub app_startup {
   my $app = $args->{app};
   my $r   = $app->routes;
 
+  delete $app->static->extra->{'favicon.ico'};
   $r->get(
     '/favicon.ico' => sub {
       my $c = shift;
diff --git a/public/favicon.ico b/public/favicon.ico
deleted file mode 100644
index c14fec40a5f221560f2231c9445f34fe70070e39..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 1150
zcmbW0Ye-XJ7{}k0m5SxC%a^{`rY)yi=5EKctC~{H%d(bASt5y=nyXn}3Xx39@KRt|
zR@&6bW?Pmi7UU%(3JUuY6x0WyJ`{na-4wHb?@1Qohl1Y2|2*$=`90^nFFb_s=)>m|
z`VJ&HUWBY6glwRqAsU&BQ$q;N{m&9*2xdgvQos9oB{b~Mh|zLA42BGEv)R1(U;PvZ
z<)cRPZV>VcJ^>ww*`hi3FJ`?}+$Jax&92K0f_!TTf<zqu=?CGxoLw8JpG-3~REtA1
zPgPzv85Z^umq|y&rBdYB3X#`l#l|=Re3l%g{OC^}Z-CkxSRIfHebjLX!g9XO=Qmc%
zMgoh3XdJ$Z{O%J-Xvs!&q6U6z`apOO!6WY|?}Yyf>x_>t5Wuhd;^F0I+0&BR2o(2m
z+)k9<u0?|F0OZCnEcM=jMPBd0<2S)?xnp*vza74QEsvU;E#V$MqEYoN)18Cj!E@Mr
zEgi<z9VqFoMcUOogtBq)@vg*T{s2}56k$`iWDJlkS(hz5?%`!uRMW}MG!)#U-|ey>
zx^)lY+jgRI=mN}k3t|tYBPq)QW0?uk5(R`75rp|7dLBaL?aX7Dje)F%LE|$Q_Vkt`
z(RCP6wsa(Rrl9KnMWi^as2;ooak&J+rQ)x_N5lmjt8!~*lwE2lI@xwryY7R@y$f|u
z?bzE_fh4yT(e3Hj-j#;tCr;E4okvKe6hW!%O^)Rj)2*9iyIJ9!NB_mnBGRtM*--~F
z@18_z&oN~590k*)Lr9GTDIJ+uZ;E;Csh@9EZhe&Ux(19xI}z(LqUE_89WU;n>Onm=
zG)R!tzYk51yAW2l386LN5LZcmpWoAixuu;@-PBBTK670=sc^86+an>jMdI*CIlAAB
zU|($sBKF50@i6l(+iyT*uc62jQ@YgCN~d}}wmhqotxlSfU16a<lyb(CUufBZ=s)+s
z<(M8Fly2>9V|}hb;bgO9cJ}i^=5IdRuZOx<AN9M}4PCOrrI}h-j|M`pjF2fFoiLgl
gqZ+3BVLI8vbYH<uIF*Hp%fF?y<5WKjsXh|&3*bRzasU7T