task(config): add MaxReportedThreads for android (#523)

* task(config): add MaxReportedThreads for android

Author: rich-bugsnag

CHANGELOG.md

@@ -6,6 +6,8 @@
 
 * Added event, session and device id persistence for Windows and WebGL builds [#512](https://github.com/bugsnag/bugsnag-unity/pull/512) [#509](https://github.com/bugsnag/bugsnag-unity/pull/509) [#514](https://github.com/bugsnag/bugsnag-unity/pull/514)
 
+* Add `Configuration.MaxReportedThreads` config option to set the [native Android option](https://docs.bugsnag.com/platforms/android/configuration-options/#maxreportedthreads) [523](https://github.com/bugsnag/bugsnag-unity/pull/523)
+
 * Update bugsnag-android to v5.20.0
   * The number of threads reported can now be limited using `Configuration.setMaxReportedThreads` (defaulting to 200)
     [bugsnag-android#1607](https://github.com/bugsnag/bugsnag-android/pull/1607)

features/android/android_custom_configs.feature

@@ -13,3 +13,11 @@ Feature: Android custom config setting
         When I run the "Custom App Type" mobile scenario
         Then I wait to receive an error
         And the event "app.type" equals "test"
+
+     Scenario: Max Reported Threads
+        When I run the "Max Reported Threads" mobile scenario
+        And I wait for 8 seconds
+        And I relaunch the Unity mobile app
+        When I run the "Start SDK" mobile scenario
+        Then I wait to receive an error
+        And the error payload field "events.0.threads" is an array with 3 elements

features/fixtures/maze_runner/Assets/Scripts/MobileScenarioRunner.cs

@@ -56,6 +56,7 @@ public class MobileScenarioRunner : MonoBehaviour {
         { "39", "Feature Flags After Init Clear All" },
         { "40", "Feature Flags In Callback" },
         { "41", "Clear Feature Flags In Callback" },
+        { "42", "Max Reported Threads" },
 
 
 
@@ -142,6 +143,9 @@ private Configuration PreapareConfigForScenario(string scenarioName)
 
         switch (scenarioName)
         {
+            case "Max Reported Threads":
+                config.MaxReportedThreads = 2;
+                break;
             case "Clear Feature Flags In Callback":
                 config.AddOnSendError((@event) => {
                     @event.AddFeatureFlag("testName3", "testVariant3");
@@ -427,6 +431,11 @@ public void DoTestAction(string scenarioName)
                 MobileNative.TriggerBackgroundJavaCrash();
 #elif UNITY_IOS
                 NativeException();
+#endif
+                break;
+            case "Max Reported Threads":
+#if UNITY_ANDROID
+                MobileNative.TriggerBackgroundJavaCrash();
 #endif
                 break;
             case "Set User After Init Csharp Error":

features/steps/unity_steps.rb

@@ -64,7 +64,7 @@ def dial_number_for(name)
       "Feature Flags After Init Clear All" => 39,
       "Feature Flags In Callback" => 40,
       "Clear Feature Flags In Callback" => 41,
-
+      "Max Reported Threads" => 42,
 
 
       # Commands

src/Assets/Bugsnag/Editor/BugsnagEditor.cs

@@ -166,6 +166,7 @@ private void DrawAdvancedSettings(SerializedObject so, BugsnagSettingsObject set
             settings.MaximumBreadcrumbs = EditorGUILayout.IntField("Max Breadcrumbs", settings.MaximumBreadcrumbs);
             EditorGUILayout.PropertyField(so.FindProperty("MaxPersistedEvents"));
             EditorGUILayout.PropertyField(so.FindProperty("MaxPersistedSessions"));
+            settings.MaxReportedThreads = EditorGUILayout.IntField(new GUIContent("Max Reported Threads ⓘ", "Android devices only"), settings.MaxReportedThreads);
             EditorGUILayout.PropertyField(so.FindProperty("NotifyLogLevel"));
             EditorGUILayout.PropertyField(so.FindProperty("PersistUser"));
             EditorGUILayout.PropertyField(so.FindProperty("RedactedKeys"));

src/Assets/Bugsnag/Scripts/BugsnagSettingsObject.cs

@@ -27,6 +27,7 @@ public class BugsnagSettingsObject : ScriptableObject
         public int MaximumBreadcrumbs = 50;
         public int MaxPersistedEvents = 32;
         public int MaxPersistedSessions = 128;
+        public int MaxReportedThreads = 200;
         public string NotifyEndpoint = "https://notify.bugsnag.com";
         public EditorLogLevel NotifyLogLevel = EditorLogLevel.Exception;
         public bool PersistUser = true;
@@ -81,6 +82,7 @@ public Configuration GetConfig()
             config.MaximumBreadcrumbs = MaximumBreadcrumbs;
             config.MaxPersistedEvents = MaxPersistedEvents;
             config.MaxPersistedSessions = MaxPersistedSessions;
+            config.MaxReportedThreads = MaxReportedThreads;
             config.NotifyLogLevel = GetLogTypeFromLogLevel( NotifyLogLevel );
             config.SendThreads = SendThreads;
             if (!string.IsNullOrEmpty(NotifyEndpoint) && !string.IsNullOrEmpty(SessionEndpoint))

src/BugsnagUnity/Configuration.cs

@@ -113,6 +113,8 @@ public int MaximumBreadcrumbs
             }
         }
 
+        public int MaxReportedThreads = 200;
+
         public string ReleaseStage = "production";
 
         public string[] EnabledReleaseStages;

src/BugsnagUnity/Native/Android/NativeInterface.cs

@@ -279,6 +279,8 @@ AndroidJavaObject CreateNativeConfig(Configuration config)
             obj.Call("setPersistUser", config.PersistUser);
             obj.Call("setLaunchDurationMillis", config.LaunchDurationMillis);
             obj.Call("setSendLaunchCrashesSynchronously", config.SendLaunchCrashesSynchronously);
+            obj.Call("setMaxReportedThreads", config.MaxReportedThreads);
+
 
             if (config.GetUser() != null)
             {