Merge branch 'master' into next

Author: kattrali

.github/ISSUE_TEMPLATE/A.md

@@ -1,12 +1,14 @@
----
-name: Having trouble getting started?
-about: Please contact us at [email protected] for assistance with integrating Bugsnag
-  into your application.
-
----
-
-<!--
-
-Are you having trouble getting started? Please contact us directly at [email protected] for assistance with integrating Bugsnag into your application.
-
--->
+---
+name: Having trouble getting started?
+about: Please contact us at [email protected] for assistance with integrating Bugsnag
+  into your application.
+title: ''
+labels: ''
+assignees: ''
+
+---
+Please checkout our [documentation](https://docs.bugsnag.com/platforms/unity/) for guides, references and tutorials.
+
+If you have questions about your integration please contact us at [[email protected]](mailto:[email protected]).
+
+Alternatively, view additional options at [support.md](../SUPPORT.md).

.github/ISSUE_TEMPLATE/Bug_report.md

@@ -1,29 +1,55 @@
 ---
 name: Bug report
 about: Create a report to help us improve the library
+title: ''
+labels: ''
+assignees: ''
+
 ---
 
+<!-- Before raising, please check if somebody else has already reported your issue. -->
+
+### Describe the bug
+A clear and concise description of what the bug is.
+
+### Steps to reproduce
+1. Go to '...'
+2. Click on '....'
+3. Scroll down to '....'
+4. See error
 
-### Description
-<!-- A quick description of what you're trying to accomplish -->
+### Environment
+* Bugsnag version:
+* Unity version:
+* iOS/Android/macOS/Windows/browser version:
+* simulator/emulator or physical device:
+* Initializing bugsnag via a Unity GameObject or in code?:
+* Player Settings:
+    * Scripting backend (Mono or IL2CPP):
+    * API compatibility level for .NET:
+    * Stack Trace level for all error types (None/ScriptOnly/Full):
 
-### Issue
 <!--
-  What went wrong?
+  Below are a few approaches you might take to communicate the issue, in
+  descending order of awesomeness. Please choose one and feel free to delete
+  the others from this template.
 -->
 
-### Environment
+### Example Repo <!-- Option 1 -->
 
-* bugsnag-unity version:
-* Unity version:
-* Operating system name and version:
-* Target platform names and versions:
-* Initializing bugsnag via the Unity UI or in code?
+- [ ] Create a minimal repository that can reproduce the issue
+- [ ] Link to it here:
 
-### Example code snippet
+### Example code snippet <!-- Option 2 -->
 
-<!-- Code snippet demonstrating your configuration and/or the problem -->
+```
+# (Insert code sample to reproduce the problem)
+```
 
-```cs
+<!-- Error messages, if any -->
+<details><summary>Error messages:</summary>
+
+```
 
 ```
+</details>

.github/ISSUE_TEMPLATE/Feature_request.md

@@ -1,19 +1,24 @@
----
-name: Feature request
-about: Suggest an idea for this project
-
----
-
-### Description
-<!-- Is your feature request related to a problem? Please describe.
-A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
--->
-
-**Describe the solution you'd like**
-<!-- A clear and concise description of what you want to happen. -->
-
-**Describe alternatives you've considered**
-<!-- A clear and concise description of any alternative solutions or features you've considered. -->
-
-**Additional context**
-Add any other context about the feature request here.
+---
+name: Feature request
+about: Suggest an idea for this project
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+<!-- Before creating, please check if somebody else has already reported your feature request. -->
+
+### Description
+<!-- Is your feature request related to a problem? Please describe.
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+-->
+
+**Describe the solution you'd like**
+<!-- A clear and concise description of what you want to happen. -->
+
+**Describe alternatives you've considered**
+<!-- A clear and concise description of any alternative solutions or features you've considered. -->
+
+**Additional context**
+<!--Add any other context about the feature request here.-->

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,84 +1,16 @@
 ## Goal
 
-<!-- What is the intent of this change?
-e.g. "When initializing the Bugsnag client, it is currently difficult to (...)
-      this change simplifies the process by (...)"
-
-     "Improves the performance of data filtering"
-
-     "Adds additional test coverage to multi-threaded use of Configuration
-      objects"
--->
-
-<!-- For new features, include design documentation:
+<!-- Why is this change necessary? -->
 
 ## Design
 
-Why was this approach to the goal used?
-
--->
+<!-- Why was this approach used? -->
 
 ## Changeset
 
-<!-- What structures or properties or functions were:
-
-### Added
-
-### Removed
-
-### Changed
-
--->
-
-## Tests
-
-<!-- How was this change tested? What manual and automated tests were
-     run/added? -->
-
-## Discussion
-
-### Alternative Approaches
-
-<!-- What other approaches were considered or discussed? -->
-
-### Outstanding Questions
-
-<!-- Are there any parts of the design or the implementation which seem
-     less than ideal and that could require additional discussion?
-     List here: -->
-
-### Linked issues
-
-<!--
-
-Fixes #
-Related to #
-
--->
-
-## Review
-
-<!-- When submitting for review, consider the points for self-review and the
-     criteria which will be used for secondary review -->
-
-For the submitter, initial self-review:
-
-- [ ] Commented on code changes inline explain the reasoning behind the approach
-- [ ] Reviewed the test cases added for completeness and possible points for discussion
-- [ ] A changelog entry was added for the goal of this pull request
-- [ ] Check the scope of the changeset - is everything in the diff required for the pull request?
-- This pull request is ready for:
-  - [ ] Initial review of the intended approach, not yet feature complete
-  - [ ] Structural review of the classes, functions, and properties modified
-  - [ ] Final review
+<!-- What changed? -->
 
-For the pull request reviewer(s), this changeset has been reviewed for:
+## Testing
 
-- [ ] Consistency across platforms for structures or concepts added or modified
-- [ ] Consistency between the changeset and the goal stated above
-- [ ] Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
-- [ ] Usage friction - is the proposed change in usage cumbersome or complicated?
-- [ ] Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
-- [ ] Concurrency concerns - if components are accessed asynchronously, what issues will arise
-- [ ] Thoroughness of added tests and any missing edge cases
-- [ ] Idiomatic use of the language
+<!-- How was it tested? What manual and automated tests were
+     run/added? -->

.github/SUPPORT.md

@@ -1,9 +1,27 @@
-Are you having trouble getting started?
-Please [contact us directly](mailto:support@bugsnag.com) for assistance with integrating Bugsnag into your application.
+## Are you having trouble getting started?
+If you haven't already, please checkout our [documentation](https://docs.bugsnag.com/platforms/unity/) for guides, references and tutorials.
 
-Include the following information to help us understand your environment:
+Or, if you wish you can [contact us directly](mailto:[email protected]) for assistance on integrating Bugsnag into your application, troubleshooting an issue or a question about our supported features.
 
-* bugsnag-unity version
-* Unity version
-* Operating system name and version
-* Target platform names and versions
+When contacting support, please include as much information as necessary, including:
+
+- example code snippet
+- steps to reproduce
+- expected/actual behaviour 
+
+* Bugsnag version:
+* Unity version:
+* iOS/Android/macOS/Windows/browser version:
+* simulator/emulator or physical device:
+* Initializing bugsnag via a Unity GameObject or in code?:
+* Player Settings:
+    * Scripting backend (Mono or IL2CPP):
+    * API compatibility level for .NET:
+    * Stack Trace level for all error types (None/ScriptOnly/Full):
+
+## Bug or Feature Requests
+If you would like to raise a bug or feature request please do so by creating a [New Issue](https://github.com/bugsnag/bugsnag-unity/issues/new/choose) and selecting bug or feature.
+Please note: we cannot promise that we will fulfil all requests
+
+## Pull Requests
+If you have made a fix and would like to raise a pull request, please read our [CONTRIBUTING.md](../CONTRIBUTING.md) file before creating the pull request.

CHANGELOG.md

@@ -1,5 +1,29 @@
 # Changelog
 
+## 4.8.3 (2020-06-10)
+
+### Bug fixes
+
+* Delete local JNI references to avoid leaks
+  [#198](https://github.com/bugsnag/bugsnag-unity/pull/198)
+
+* Add option to `Configuration` to prevent automatic breadcrumb collection
+  [#199](https://github.com/bugsnag/bugsnag-unity/pull/199)
+
+## 4.8.2 (2020-03-31)
+
+### Bug fixes
+
+* Avoid using deprecated AndroidJNI API in Unity 2019
+  [#194](https://github.com/bugsnag/bugsnag-unity/pull/194)
+
+## 4.8.1 (2020-02-04)
+
+### Bug fixes
+
+* (Android) Propagate non-string arguments to native android layer correctly
+  [#191](https://github.com/bugsnag/bugsnag-unity/pull/191)
+
 ## 4.8.0 (2020-01-27)
 
 ### Enhancements

build.cake

@@ -5,7 +5,7 @@ var target = Argument("target", "Default");
 var solution = File("./BugsnagUnity.sln");
 var configuration = Argument("configuration", "Release");
 var project = File("./src/BugsnagUnity/BugsnagUnity.csproj");
-var version = "4.8.0";
+var version = "4.8.3";
 
 Task("Restore-NuGet-Packages")
     .Does(() => NuGetRestore(solution));

src/BugsnagUnity/Client.cs

@@ -127,7 +127,7 @@ void Notify(string condition, string stackTrace, LogType logType)
       {
         var logMessage = new UnityLogMessage(condition, stackTrace, logType);
         var shouldSend = Exception.ShouldSend(logMessage)
-          && UniqueCounter.ShouldSend(logMessage) 
+          && UniqueCounter.ShouldSend(logMessage)
           && LogTypeCounter.ShouldSend(logMessage);
         if (shouldSend)
         {
@@ -138,7 +138,7 @@ void Notify(string condition, string stackTrace, LogType logType)
           Notify(new Exception[]{exception}, exception.HandledState, null, logType);
         }
       }
-      else
+      else if (logType.IsGreaterThanOrEqualTo(Configuration.BreadcrumbLogLevel))
       {
         Breadcrumbs.Leave(logType.ToString(), BreadcrumbType.Log, new Dictionary<string, string> {
           { "message", condition },

src/BugsnagUnity/Configuration.cs

@@ -35,6 +35,8 @@ protected virtual void SetupDefaults(string apiKey)
 
     public virtual TimeSpan UniqueLogsTimePeriod { get; set; } = TimeSpan.FromSeconds(5);
 
+    public virtual LogType BreadcrumbLogLevel { get; set; } = LogType.Log;
+
     public virtual string ApiKey { get; protected set; }
 
     public virtual int MaximumBreadcrumbs { get; set; } = 25;

src/BugsnagUnity/IConfiguration.cs

@@ -12,6 +12,8 @@ public interface IConfiguration
 
     TimeSpan MaximumLogsTimePeriod { get; }
 
+    LogType BreadcrumbLogLevel { get; set; }
+
     Dictionary<LogType, int> MaximumTypePerTimePeriod { get; }
 
     TimeSpan UniqueLogsTimePeriod { get; set; }