Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error for invalid manifest format #9

Open
djfarrelly opened this issue Dec 21, 2017 · 0 comments
Open

Throw error for invalid manifest format #9

djfarrelly opened this issue Dec 21, 2017 · 0 comments
Labels

Comments

@djfarrelly
Copy link
Contributor

We should return an error here:

// FormatManifest returns the file version manifest in json or csv format
func FormatManifest(fileVersions map[string]string, format string) ([]byte, error) {
if format == "json" {
return json.MarshalIndent(fileVersions, "", " ")
}
if format == "csv" {
b := &bytes.Buffer{}
wr := csv.NewWriter(b)
for filename, uri := range fileVersions {
row := []string{filename, uri}
wr.Write(row)
}
wr.Flush()
return b.Bytes(), nil
}
return nil, nil
}

@djfarrelly djfarrelly added the bug label Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant