Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spot websocket connection doesn't get closed properly #319

Closed
btschwertfeger opened this issue Nov 25, 2024 · 0 comments · Fixed by #318
Closed

Spot websocket connection doesn't get closed properly #319

btschwertfeger opened this issue Nov 25, 2024 · 0 comments · Fixed by #318
Assignees
Labels
Bug Something isn't working
Milestone

Comments

@btschwertfeger
Copy link
Owner

Since websockets==14.0, they changed the backend to a "new" asyncio implementation, changing the default value of max_queue from None to 16. This causes troubles in high-traffic connections, as they can't be properly closed and remain stuck.

In order to avoid this, max_queue can be set back to None temporarily, as the documentation of websockets states that this is not recommended.

Since the cancellation error seems to be some kind of buffer overflow or other kind of trouble, I already created an issue at python-websockets/websockets#1555, which hopefully get addressed soon.

@btschwertfeger btschwertfeger added the Bug Something isn't working label Nov 25, 2024
@btschwertfeger btschwertfeger self-assigned this Nov 25, 2024
@btschwertfeger btschwertfeger added this to the v3.1.2 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant