Skip to content

Miri flag passing changed #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RalfJung opened this issue Sep 21, 2020 · 1 comment
Open

Miri flag passing changed #1

RalfJung opened this issue Sep 21, 2020 · 1 comment

Comments

@RalfJung
Copy link

cargo miri test changed to be more compatible with cargo test, but this means we had to find a different way to pass flags to the interpreter, so there now is a MIRIFLAGS environment variable for that. The old way still works for now, but is deprecated.

This affects the following line:

cargo miri test -p memcpy --target-dir="$MIRI_DIR" -- -Zmiri-disable-isolation

This should now be MIRIFLAGS="-Zmiri-disable-isolation" cargo miri test -p memcpy --target-dir="$MIRI_DIR".

@RalfJung
Copy link
Author

Heads-up: I am planning to remove the compatibility hack that made passing Miri flags as cargo arguments still work (rust-lang/miri#1769). Once this lands, CI here will break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant