Skip to content

Pass test info for android #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Pass test info for android #18

wants to merge 2 commits into from

Conversation

asambstack
Copy link
Contributor

@asambstack asambstack commented Dec 20, 2023 •
edited
Loading

Params such as baseUrl weren't being honoured from playwright.config.js for mobile devices as the testInfo wasn't being passed during context creation.

@asambstack asambstack requested a review from a team as a code owner December 20, 2023 14:10
@shirish87
Copy link
Collaborator

Without this, tests that use relative URLs fail on android devices.
Also worth marking failed tests in the API.

Working sample:
https://github.com/shirish87/nextjs-with-playwright-browserstack/tree/main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asambstack @shirish87