Skip to content

Commit 1e3475b

Browse files
Added Exception loggin
1 parent 6467826 commit 1e3475b

File tree

2 files changed

+15
-5
lines changed

2 files changed

+15
-5
lines changed

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,6 @@ local.log
44
dist/**
55
MANIFEST
66

7+
venv
8+
build
9+
browserstack_local.egg-info

browserstack/local.py

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
1-
import subprocess, os, time, json, psutil
1+
import subprocess, os, time, json,logging
2+
import psutil
3+
24
from browserstack.local_binary import LocalBinary
35
from browserstack.bserrors import BrowserStackLocalError
46

7+
logger = logging.getLogger(__name__)
8+
59
class Local:
610
def __init__(self, key=None, binary_path=None, **kwargs):
711
self.key = os.environ['BROWSERSTACK_ACCESS_KEY'] if 'BROWSERSTACK_ACCESS_KEY' in os.environ else key
@@ -51,22 +55,25 @@ def start(self, **kwargs):
5155
if "onlyCommand" in kwargs and kwargs["onlyCommand"]:
5256
return
5357

54-
self.proc = subprocess.Popen(self._generate_cmd(), stdout=subprocess.PIPE, stderr=subprocess.PIPE)
58+
self.proc = subprocess.Popen('ls', stdout=subprocess.PIPE, stderr=subprocess.PIPE)
5559
(out, err) = self.proc.communicate()
5660

5761
os.system('echo "" > "'+ self.local_logfile_path +'"')
5862
try:
5963
if out:
60-
data = json.loads(out.decode())
64+
output_string = out.decode()
6165
else:
62-
data = json.loads(err.decode())
66+
output_string = err.decode()
67+
68+
data = json.loads(output_string)
6369

6470
if data['state'] != "connected":
6571
raise BrowserStackLocalError(data["message"]["message"])
6672
else:
6773
self.pid = data['pid']
6874
except ValueError:
69-
raise BrowserStackLocalError('Error parsing JSON output from daemon')
75+
logger.error("BinaryOutputParseError: Raw String = '{}'".format(output_string) )
76+
raise BrowserStackLocalError('Error parsing JSON output from daemon. Raw String = "{}"'.format(output_string))
7077

7178
def isRunning(self):
7279
return hasattr(self, 'pid') and psutil.pid_exists(self.pid)

0 commit comments

Comments
 (0)