Skip to content

Commit f5c58d0

Browse files
committed
Use library for https proxy agent instead of local one
The library version also runs with node v.0.10.x
1 parent e14efc3 commit f5c58d0

File tree

3 files changed

+4
-126
lines changed

3 files changed

+4
-126
lines changed

lib/HttpsProxyAgent.js

Lines changed: 0 additions & 123 deletions
This file was deleted.

lib/LocalBinary.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ var https = require('https'),
33
fs = require('fs'),
44
path = require('path'),
55
os = require('os'),
6-
HttpsProxyAgent = require('./HttpsProxyAgent'),
6+
HttpsProxyAgent = require('https-proxy-agent'),
77
LocalError = require('./LocalError');
88

99
function LocalBinary(){
@@ -33,8 +33,8 @@ function LocalBinary(){
3333
var options = url.parse(this.httpPath);
3434
if(conf.proxyHost && conf.proxyPort){
3535
options.agent = new HttpsProxyAgent({
36-
proxyHost: conf.proxyHost,
37-
proxyPort: conf.proxyPort
36+
host: conf.proxyHost,
37+
port: conf.proxyPort
3838
});
3939
}
4040

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
"author": "BrowserStack",
1818
"license": "MIT",
1919
"dependencies": {
20+
"https-proxy-agent": "^1.0.0",
2021
"is-running": "^2.0.0"
2122
},
2223
"devDependencies": {

0 commit comments

Comments
 (0)