resolved comments

roshan04 · roshan04 · commit efcb0daf4317 · 2022-03-24T18:18:04.000+05:30
diff --git a/bin/helpers/capabilityHelper.js b/bin/helpers/capabilityHelper.js
@@ -242,10 +242,10 @@ const validate = (bsConfig, args) => {
     }
 
     if(!Utils.isUndefined(bsConfig.run_settings["record"]) && String(bsConfig.run_settings["record"]) == 'true') {
-      if(Utils.isUndefined(bsConfig.run_settings.projectId)) {
+      if(Utils.isUndefined(bsConfig.run_settings.projectId) || bsConfig.run_settings.projectId == "" ) {
         logger.warn(Constants.validationMessages.PROJECT_ID_MISSING);
       } 
-      if (Utils.isUndefined(bsConfig.run_settings["record-key"])) {
+      if (Utils.isUndefined(bsConfig.run_settings["record-key"]) ||  bsConfig.run_settings["record-key"] == "" ) {
         logger.warn(Constants.validationMessages.RECORD_KEY_MISSING);
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -242,10 +242,10 @@ const validate = (bsConfig, args) => {`
`242`	`242`	`}`
`243`	`243`
`244`	`244`	`if(!Utils.isUndefined(bsConfig.run_settings["record"]) && String(bsConfig.run_settings["record"]) == 'true') {`
`245`		`- if(Utils.isUndefined(bsConfig.run_settings.projectId)) {`
	`245`	`+ if(Utils.isUndefined(bsConfig.run_settings.projectId) \|\| bsConfig.run_settings.projectId == "" ) {`
`246`	`246`	`logger.warn(Constants.validationMessages.PROJECT_ID_MISSING);`
`247`	`247`	`}`
`248`		`- if (Utils.isUndefined(bsConfig.run_settings["record-key"])) {`
	`248`	`+ if (Utils.isUndefined(bsConfig.run_settings["record-key"]) \|\| bsConfig.run_settings["record-key"] == "" ) {`
`249`	`249`	`logger.warn(Constants.validationMessages.RECORD_KEY_MISSING);`
`250`	`250`	`}`
`251`	`251`	`}`