Skip to content

Commit b925549

Browse files
07souravkundafrancisf
authored andcommitted
change node_module warn message and purge upload bar
1 parent f1aec3d commit b925549

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

bin/helpers/zipUpload.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,11 @@ const uploadSuits = (bsConfig, filePath, opts, obj) => {
6969
}
7070
}
7171
if (!opts.propogateError){
72+
purgeUploadBar(obj);
7273
if (resp.statusCode == 413) {
73-
logger.warn("node_modules upload failed as the size is more than 200 MB. Dependencies will be installed in runtime. This will have a negative impact on performance.");
74+
return resolve({warn: `node_modules upload failed as the size ${(size / 1000000).toFixed(2)} MB is not supported. Dependencies will be installed in runtime. This will have a negative impact on build performance. Reach out to us at browserstack.com/support if you see this warning.`});
7475
}
75-
return resolve({});
76+
return resolve({})
7677
}
7778
if(responseData && responseData["error"]){
7879
responseData["time"] = Date.now() - obj.startTime;
@@ -140,6 +141,9 @@ const uploadCypressZip = (bsConfig, md5data, packageData) => {
140141
let npmPackageUpload = uploadSuits(bsConfig, config.packageFileName, npmOptions, npmPackageZipUploadObj);
141142
Promise.all([zipUpload, npmPackageUpload]).then(function (uploads) {
142143
uploads.forEach(upload => {
144+
if(upload.warn) {
145+
logger.warn(upload.warn);
146+
}
143147
if(upload.zip_url && upload.time) {
144148
upload.tests_upload_time = upload.time;
145149
} else if (upload.npm_package_url && upload.time) {

0 commit comments

Comments
 (0)