Skip to content

Commit b8fd2b7

Browse files
Merge pull request #209 from browserstack/package_err
Handle errors raised without a stacktrace while zipping
2 parents a33eec2 + a0ae30d commit b8fd2b7

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

bin/helpers/checkUploaded.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,8 @@ const checkUploadedMd5 = (bsConfig, args, instrumentBlocks) => {
145145
}
146146
});
147147
}).catch((err) => {
148-
resolve({zipUrlPresent: false, packageUrlPresent: false, error: err.stack.substring(0,100)});
148+
let errString = err.stack ? err.stack.toString().substring(0,100) : err.toString().substring(0,100);
149+
resolve({zipUrlPresent: false, packageUrlPresent: false, error: errString});
149150
});
150151
});
151152
};

bin/helpers/packageInstaller.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ const packageWrapper = (bsConfig, packageDir, packageFile, md5data, instrumentBl
125125
Object.assign(obj, { packageArchieveCreated: true });
126126
return resolve(obj);
127127
}).catch((err) => {
128-
obj.error = err.stack.substring(0,100);
128+
obj.error = err.stack ? err.stack.toString().substring(0,100) : err.toString().substring(0,100);
129129
return resolve(obj);
130130
})
131131
})

0 commit comments

Comments
 (0)