Skip to content

Commit b6d9aa1

Browse files
Roshan NikamRoshan Nikam
Roshan Nikam
authored and
Roshan Nikam
committed
added spec for raw logs
1 parent 9c2b2f4 commit b6d9aa1

File tree

5 files changed

+92
-35
lines changed

5 files changed

+92
-35
lines changed

‎test/unit/bin/commands/info.js

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ logger.transports["console.info"].silent = true;
1414

1515
describe("buildInfo", () => {
1616
let args = testObjects.buildInfoSampleArgs;
17+
let rawArgs = testObjects.buildInfoSampleRawArgs;
1718
let body = testObjects.buildInfoSampleBody;
1819
let bsConfig = testObjects.sampleBsConfig;
1920

@@ -66,12 +67,12 @@ describe("buildInfo", () => {
6667

6768
validateBstackJsonStub.returns(Promise.resolve(bsConfig));
6869

69-
return info(args)
70+
return info(args, rawArgs)
7071
.then(function (_bsConfig) {
7172
sinon.assert.calledOnce(requestStub);
7273
sinon.assert.calledOnce(getConfigPathStub);
7374
sinon.assert.calledOnce(getUserAgentStub);
74-
sinon.assert.calledOnceWithExactly(sendUsageReportStub, bsConfig, args, message, messageType, errorCode);
75+
sinon.assert.calledOnceWithExactly(sendUsageReportStub, bsConfig, args, message, messageType, errorCode, null, rawArgs);
7576
}).catch((error) => {
7677
chai.assert.isNotOk(error,'Promise error');
7778
});
@@ -104,12 +105,12 @@ describe("buildInfo", () => {
104105

105106
validateBstackJsonStub.returns(Promise.resolve(bsConfig));
106107

107-
return info(args)
108+
return info(args, rawArgs)
108109
.then(function (_bsConfig) {
109110
sinon.assert.calledOnce(requestStub);
110111
sinon.assert.calledOnce(getUserAgentStub);
111112
sinon.assert.calledOnce(getConfigPathStub);
112-
sinon.assert.calledOnceWithExactly(sendUsageReportStub, bsConfig, args, message, messageType, errorCode);
113+
sinon.assert.calledOnceWithExactly(sendUsageReportStub, bsConfig, args, message, messageType, errorCode, null, rawArgs);
113114
})
114115
.catch((error) => {
115116
chai.assert.isNotOk(error, "Promise error");
@@ -166,12 +167,12 @@ describe("buildInfo", () => {
166167

167168
validateBstackJsonStub.returns(Promise.resolve(bsConfig));
168169

169-
return info(args)
170+
return info(args, rawArgs)
170171
.then(function (_bsConfig) {
171172
sinon.assert.calledOnce(requestStub);
172173
sinon.assert.calledOnce(getUserAgentStub);
173174
sinon.assert.calledOnce(getConfigPathStub);
174-
sinon.assert.calledOnceWithExactly(sendUsageReportStub, bsConfig, args, message, messageType, errorCode);
175+
sinon.assert.calledOnceWithExactly(sendUsageReportStub, bsConfig, args, message, messageType, errorCode, null, rawArgs);
175176
})
176177
.catch((error) => {
177178
chai.assert.isNotOk(error, "Promise error");
@@ -210,12 +211,12 @@ describe("buildInfo", () => {
210211

211212
validateBstackJsonStub.returns(Promise.resolve(bsConfig));
212213

213-
return info(args)
214+
return info(args, rawArgs)
214215
.then(function (_bsConfig) {
215216
sinon.assert.calledOnce(requestStub);
216217
sinon.assert.calledOnce(getUserAgentStub);
217218
sinon.assert.calledOnce(getConfigPathStub);
218-
sinon.assert.calledOnceWithExactly(sendUsageReportStub, bsConfig, args, message, messageType, errorCode);
219+
sinon.assert.calledOnceWithExactly(sendUsageReportStub, bsConfig, args, message, messageType, errorCode, null, rawArgs);
219220
})
220221
.catch((error) => {
221222
chai.assert.isNotOk(error, "Promise error");
@@ -249,12 +250,12 @@ describe("buildInfo", () => {
249250

250251
validateBstackJsonStub.returns(Promise.resolve(bsConfig));
251252

252-
return info(args)
253+
return info(args, rawArgs)
253254
.then(function (_bsConfig) {
254255
sinon.assert.calledOnce(requestStub);
255256
sinon.assert.calledOnce(getUserAgentStub);
256257
sinon.assert.calledOnce(getConfigPathStub);
257-
sinon.assert.calledOnceWithExactly(sendUsageReportStub, bsConfig, args, message, messageType, errorCode);
258+
sinon.assert.calledOnceWithExactly(sendUsageReportStub, bsConfig, args, message, messageType, errorCode, null, rawArgs);
258259
})
259260
.catch((error) => {
260261
chai.assert.isNotOk(error, "Promise error");
@@ -311,12 +312,12 @@ describe("buildInfo", () => {
311312

312313
validateBstackJsonStub.returns(Promise.resolve(bsConfig));
313314

314-
return info(args)
315+
return info(args, rawArgs)
315316
.then(function (_bsConfig) {
316317
sinon.assert.calledOnce(requestStub);
317318
sinon.assert.calledOnce(getUserAgentStub);
318319
sinon.assert.calledOnce(getConfigPathStub);
319-
sinon.assert.calledOnceWithExactly(sendUsageReportStub, bsConfig, args, message, messageType, errorCode);
320+
sinon.assert.calledOnceWithExactly(sendUsageReportStub, bsConfig, args, message, messageType, errorCode, null, rawArgs);
320321
}).catch((error) => {
321322
chai.assert.isNotOk(error,'Promise error');
322323
});
@@ -363,11 +364,11 @@ describe("buildInfo", () => {
363364

364365
validateBstackJsonStub.returns(Promise.reject({ message: "reject error" }));
365366

366-
return info(args)
367+
return info(args, rawArgs)
367368
.then(function (_bsConfig) {
368369
chai.assert.fail("Promise error");
369370
}).catch((error) => {
370-
sinon.assert.calledOnceWithExactly(sendUsageReportStub, null, args, "reject error", Constants.messageTypes.ERROR, "random-error");
371+
sinon.assert.calledOnceWithExactly(sendUsageReportStub, null, args, "reject error", Constants.messageTypes.ERROR, "random-error", null, rawArgs);
371372
});
372373
});
373374
});

‎test/unit/bin/commands/init.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ logger.transports["console.info"].silent = true;
2121

2222
describe("init", () => {
2323
let args = testObjects.initSampleArgs;
24+
let rawArgs = testObjects.initSampleRawArgs;
2425
var sandbox;
2526

2627
beforeEach(() => {
@@ -132,10 +133,10 @@ describe("init", () => {
132133
}
133134
});
134135

135-
init(args);
136+
init(args, rawArgs);
136137
sinon.assert.calledOnce(dirExistsStub);
137138
sinon.assert.notCalled(writeStub);
138-
sinon.assert.calledOnceWithExactly(sendUsageReportStub, null, args, Constants.userMessages.DIR_NOT_FOUND, Constants.messageTypes.ERROR, 'path_to_init_not_found');
139+
sinon.assert.calledOnceWithExactly(sendUsageReportStub, null, args, Constants.userMessages.DIR_NOT_FOUND, Constants.messageTypes.ERROR, 'path_to_init_not_found', null, rawArgs);
139140
});
140141

141142
it("fail if browserstack.json is already present", () => {
@@ -154,11 +155,11 @@ describe("init", () => {
154155
},
155156
});
156157

157-
init(args);
158+
init(args, rawArgs);
158159
sinon.assert.calledOnce(dirExistsStub);
159160
sinon.assert.calledOnce(fileExistsStub);
160161
sinon.assert.notCalled(writeStub);
161-
sinon.assert.calledOnceWithExactly(sendUsageReportStub, null, args, Constants.userMessages.CONFIG_FILE_EXISTS, Constants.messageTypes.ERROR, 'bstack_json_already_exists');
162+
sinon.assert.calledOnceWithExactly(sendUsageReportStub, null, args, Constants.userMessages.CONFIG_FILE_EXISTS, Constants.messageTypes.ERROR, 'bstack_json_already_exists', null, rawArgs);
162163
});
163164

164165
it("create browserstack.json if not already present", () => {
@@ -178,7 +179,7 @@ describe("init", () => {
178179
},
179180
});
180181

181-
init(args);
182+
init(args, rawArgs);
182183
sinon.assert.calledOnce(dirExistsStub);
183184
sinon.assert.calledOnce(fileExistsStub);
184185
sinon.assert.calledOnce(writeStub);

‎test/unit/bin/commands/runs.js

Lines changed: 27 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ logger.transports["console.info"].silent = true;
1313

1414
describe("runs", () => {
1515
let args = testObjects.runSampleArgs;
16+
let rawArgs = testObjects.runSampleRawArgs;
1617
let bsConfig = testObjects.sampleBsConfig;
1718

1819
describe("handle browserstack.json not valid", () => {
@@ -28,6 +29,7 @@ describe("runs", () => {
2829
});
2930
getErrorCodeFromErrStub = sandbox.stub().returns("random-error-code");
3031
deleteResultsStub = sandbox.stub();
32+
readBsConfigJSONStub = sandbox.stub().returns(null);
3133
});
3234

3335
afterEach(() => {
@@ -47,13 +49,14 @@ describe("runs", () => {
4749
sendUsageReport: sendUsageReportStub,
4850
setUsageReportingFlag: setUsageReportingFlagStub,
4951
getConfigPath: getConfigPathStub,
50-
deleteResults: deleteResultsStub
52+
deleteResults: deleteResultsStub,
53+
readBsConfigJSON: readBsConfigJSONStub
5154
},
5255
});
5356

5457
validateBstackJsonStub.returns(Promise.reject({ message: "random-error" }));
5558

56-
return runs(args)
59+
return runs(args, rawArgs)
5760
.then(function (_bsConfig) {
5861
chai.assert.fail("Promise error");
5962
})
@@ -70,7 +73,9 @@ describe("runs", () => {
7073
args,
7174
message,
7275
messageType,
73-
errorCode
76+
errorCode,
77+
null,
78+
rawArgs
7479
);
7580
});
7681
});
@@ -160,7 +165,7 @@ describe("runs", () => {
160165
setupLocalTestingStub.returns(Promise.resolve("return nothing"));
161166
capabilityValidatorStub.returns(Promise.reject("random-error"));
162167

163-
return runs(args)
168+
return runs(args, rawArgs)
164169
.then(function (_bsConfig) {
165170
chai.assert.fail("Promise error");
166171
})
@@ -195,7 +200,9 @@ describe("runs", () => {
195200
args,
196201
message,
197202
messageType,
198-
errorCode
203+
errorCode,
204+
null,
205+
rawArgs
199206
);
200207
});
201208
});
@@ -310,7 +317,7 @@ describe("runs", () => {
310317
packageInstallerStub.returns(Promise.resolve({ packageArchieveCreated: false }));
311318
archiverStub.returns(Promise.reject("random-error"));
312319

313-
return runs(args)
320+
return runs(args, rawArgs)
314321
.then(function (_bsConfig) {
315322
chai.assert.fail("Promise error");
316323
})
@@ -347,7 +354,9 @@ describe("runs", () => {
347354
args,
348355
message,
349356
messageType,
350-
errorCode
357+
errorCode,
358+
null,
359+
rawArgs
351360
);
352361
});
353362
});
@@ -467,7 +476,7 @@ describe("runs", () => {
467476
archiverStub.returns(Promise.resolve("Zipping completed"));
468477
zipUploadStub.returns(Promise.reject("random-error"));
469478

470-
return runs(args)
479+
return runs(args, rawArgs)
471480
.then(function (_bsConfig) {
472481
chai.assert.fail("Promise error");
473482
})
@@ -500,7 +509,9 @@ describe("runs", () => {
500509
args,
501510
message,
502511
messageType,
503-
errorCode
512+
errorCode,
513+
null,
514+
rawArgs
504515
);
505516
})
506517
.finally(function () {
@@ -633,7 +644,7 @@ describe("runs", () => {
633644
stopLocalBinaryStub.returns(Promise.resolve("nothing"));
634645
createBuildStub.returns(Promise.reject("random-error"));
635646

636-
return runs(args)
647+
return runs(args, rawArgs)
637648
.then(function (_bsConfig) {
638649
chai.assert.fail("Promise error");
639650
})
@@ -671,7 +682,9 @@ describe("runs", () => {
671682
args,
672683
message,
673684
messageType,
674-
errorCode
685+
errorCode,
686+
null,
687+
rawArgs
675688
);
676689
});
677690
});
@@ -835,7 +848,7 @@ describe("runs", () => {
835848
getParallelsStub.returns(10);
836849
createBuildStub.returns(Promise.resolve({ message: 'Success', build_id: 'random_build_id', dashboard_url: dashboardUrl, user_id: 1234 }));
837850

838-
return runs(args)
851+
return runs(args, rawArgs)
839852
.then(function (_bsConfig) {
840853
chai.assert.fail("Promise error");
841854
})
@@ -875,7 +888,8 @@ describe("runs", () => {
875888
`${message}\n${dashboardLink}`,
876889
messageType,
877890
errorCode,
878-
data
891+
data,
892+
rawArgs
879893
]
880894
);
881895
});

‎test/unit/bin/commands/stop.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ logger.transports["console.info"].silent = true;
1414

1515
describe("buildStop", () => {
1616
let args = testObjects.buildStopSampleArgs;
17+
let rawArgs = testObjects.buildStopSampleRawArgs;
1718
let body = testObjects.buildStopSampleBody;
1819
let bsConfig = testObjects.sampleBsConfig;
1920

@@ -60,7 +61,7 @@ describe("buildStop", () => {
6061

6162
validateBstackJsonStub.returns(Promise.resolve(bsConfig));
6263

63-
return stop(args)
64+
return stop(args, rawArgs)
6465
.then(function (_bsConfig) {
6566
sinon.assert.calledOnce(stopBrowserStackBuildStub);
6667
})
@@ -109,7 +110,7 @@ describe("buildStop", () => {
109110
Promise.reject({ message: "reject error" })
110111
);
111112

112-
return stop(args)
113+
return stop(args, rawArgs)
113114
.then(function (_bsConfig) {
114115
chai.assert.fail("Promise error");
115116
})
@@ -120,7 +121,9 @@ describe("buildStop", () => {
120121
args,
121122
"reject error",
122123
Constants.messageTypes.ERROR,
123-
"random-error"
124+
"random-error",
125+
null,
126+
rawArgs
124127
);
125128
});
126129
});

0 commit comments

Comments
 (0)