Resolve phpstan issues

Author: brotkrueml

Classes/Core/ViewHelpers/SchemaViewHelperResolverDelegate.php

@@ -11,20 +11,13 @@
 
 namespace Brotkrueml\Schema\Core\ViewHelpers;
 
-use Brotkrueml\Schema\Type\ModelClassNotFoundException;
-use TYPO3Fluid\Fluid\Core\ViewHelper\ViewHelperInterface;
 use TYPO3Fluid\Fluid\Core\ViewHelper\ViewHelperResolverDelegateInterface;
 
 /**
  * @internal
  */
 final readonly class SchemaViewHelperResolverDelegate implements ViewHelperResolverDelegateInterface
 {
-    /**
-     * @param string $name ViewHelper name as written in the template, for example "type.person"
-     * @return class-string<ViewHelperInterface>
-     * @throws ModelClassNotFoundException
-     */
     public function resolveViewHelperClassName(string $name): string
     {
         if (\str_starts_with($name, 'type.')) {
@@ -33,11 +26,14 @@ public function resolveViewHelperClassName(string $name): string
 
         $explodedViewHelperName = \explode('.', $name);
 
-        return \sprintf(
+        /** @var class-string $class */
+        $class = \sprintf(
             '%s\%sViewHelper',
             $this->getNamespace(),
             \implode('\\', \array_map(ucfirst(...), $explodedViewHelperName)),
         );
+
+        return $class;
     }
 
     public function getNamespace(): string

Classes/Core/ViewHelpers/TypeViewHelper.php

@@ -13,6 +13,7 @@
 
 use Brotkrueml\Schema\Core\Model\TypeInterface;
 use Brotkrueml\Schema\Type\TypeFactory;
+use TYPO3Fluid\Fluid\Core\Parser\SyntaxTree\ViewHelperNode;
 use TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper;
 use TYPO3Fluid\Fluid\Core\ViewHelper\ArgumentDefinition;
 
@@ -24,7 +25,7 @@ final class TypeViewHelper extends AbstractViewHelper
     private TypeInterface $schemaType;
 
     /**
-     * @var array<string, list<ArgumentDefinition>>
+     * @var array<string, array<string, ArgumentDefinition>>
      */
     private static array $typeArgumentDefinitions = [];
 
@@ -45,10 +46,11 @@ public function setArguments(array $arguments): void
     }
 
     /**
-     * @return list<ArgumentDefinition>
+     * @return array<string, ArgumentDefinition>
      */
     public function prepareArguments(): array
     {
+        \assert($this->viewHelperNode instanceof ViewHelperNode);
         $name = $this->viewHelperNode->getName();
         if (! \str_starts_with($name, 'type.')) {
             // There is something wrong, this should not happen
@@ -66,7 +68,7 @@ public function prepareArguments(): array
         if (! isset(self::$typeArgumentDefinitions[$typeName])) {
             self::$typeArgumentDefinitions[$typeName] = $this->getNotableArguments();
             foreach ($this->schemaType->getPropertyNames() as $propertyName) {
-                self::$typeArgumentDefinitions[$this->schemaType->getType()][$propertyName] = new ArgumentDefinition(
+                self::$typeArgumentDefinitions[$typeName][$propertyName] = new ArgumentDefinition(
                     $propertyName,
                     'mixed',
                     \sprintf('Property "%s"', $propertyName),
@@ -75,11 +77,11 @@ public function prepareArguments(): array
             }
         }
 
-        return self::$typeArgumentDefinitions[$this->schemaType->getType()];
+        return self::$typeArgumentDefinitions[$typeName];
     }
 
     /**
-     * @return array<string, list<ArgumentDefinition>>
+     * @return array<string, ArgumentDefinition>
      */
     private function getNotableArguments(): array
     {