Skip to content

Commit ef6c64c

Browse files
authored
Merge pull request #123 from broadinstitute/jb-dense-cell-name-idx
addressing off-by-one error when aligning cell names w/ scores (SCP-2656)
2 parents f1ee8c7 + 53730f8 commit ef6c64c

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

ingest/expression_files/dense_ingestor.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ def filter_expression_scores(scores: List, cells: List):
9292
"""
9393
associated_cells = []
9494
valid_expression_scores = []
95-
for idx, expression_score in enumerate(scores, 1):
95+
for idx, expression_score in enumerate(scores):
9696
try:
9797
if (
9898
expression_score != "0"
@@ -105,7 +105,8 @@ def filter_expression_scores(scores: List, cells: List):
105105
float(expression_score)
106106
):
107107
valid_expression_scores.append(expression_score)
108-
associated_cells.append(cells[idx])
108+
# add one to account for gene name in scores list
109+
associated_cells.append(cells[idx + 1])
109110
except Exception:
110111
raise ValueError("Score '{expression_score}' is not valid")
111112
return valid_expression_scores, associated_cells

0 commit comments

Comments
 (0)