Skip to content

Commit 5c777c8

Browse files
authored
Merge pull request #403 from broadinstitute/development
Release 1.43.1
2 parents 36d165a + 9a4878e commit 5c777c8

File tree

13 files changed

+47
-5
lines changed

13 files changed

+47
-5
lines changed

Dockerfile

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010
# Use a managed base image from Google. It is continually updated for
1111
# security fixes (thus the "latest" tag).
1212
# https://github.com/GoogleContainerTools/base-images-docker/tree/master/ubuntu
13-
FROM marketplace.gcr.io/google/ubuntu2004:latest
13+
FROM marketplace.gcr.io/google/ubuntu2204:latest
14+
ENV DEBIAN_FRONTEND=noninteractive
1415

1516
# RUN echo "Uncomment to clear cached layers below this statement (2022-03-14-1441)"
1617

@@ -21,7 +22,8 @@ RUN apt-get -y update && \
2122
apt-get -y install python3-pip && \
2223
apt-get -y install python3.10 && \
2324
apt-get -y install python3.10-dev && \
24-
apt-get -y install python3.10-distutils
25+
apt-get -y install python3.10-distutils && \
26+
apt-get -y remove python3-blinker # due to pip install errors of distutils package
2527

2628
RUN apt-get -y update && apt-get -y install curl
2729

README.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,14 @@ source env/bin/activate
2929
pip install -r requirements.txt
3030
source scripts/setup-mongo-dev.sh
3131
```
32+
Note: if you encounter the following error:
33+
```
34+
AttributeError: module 'coverage' has no attribute 'types'
35+
```
36+
You can run the following to address this:
37+
```
38+
pip install --upgrade coverage
39+
```
3240

3341
### Docker
3442

4.54 KB
Binary file not shown.
1.01 KB
Binary file not shown.
359 Bytes
Binary file not shown.
1.46 KB
Binary file not shown.
9.13 KB
Binary file not shown.
475 Bytes
Binary file not shown.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1752088054 # validation cache key
1+
1764620615 # validation cache key

ingest/validation/validate_metadata.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -476,8 +476,17 @@ def retrieve_label_and_synonyms(
476476
:param property_type: attribute type for term (string, array, boolean)
477477
"""
478478
ontology_name = re.split("[_:]", ontology_id)[0].lower()
479-
if ontology_is_local(ontology_name):
479+
# use OLS fallback for taxon IDs since minified version is not authoritative
480+
use_fallback = ontology_name == "ncbitaxon"
481+
if ontology_is_local(ontology_name) and not use_fallback:
480482
return minified_reader.find_ontology_entry(ontology_name, ontology_id, property_name)
483+
elif ontology_is_local(ontology_name) and use_fallback:
484+
try:
485+
return minified_reader.find_ontology_entry(ontology_name, ontology_id, property_name)
486+
except ValueError:
487+
return retriever.retrieve_ontology_term_label_and_synonyms(
488+
ontology_id, property_name, convention, property_type
489+
)
481490
else:
482491
return retriever.retrieve_ontology_term_label_and_synonyms(
483492
ontology_id, property_name, convention, property_type

0 commit comments

Comments
 (0)