Skip to content

Commit 1baf6f7

Browse files
committed
Remove Firestore emulator set-up in CircleCI
1 parent 62783fa commit 1baf6f7

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

tests/gcp_mocks.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,3 +52,10 @@ def download_to_filename(self, filename):
5252
copyfile(self.name, filename)
5353

5454
return MockStorageBlob(*args, **kwargs)
55+
56+
57+
def mock_firestore_client():
58+
"""Mocks firestore.Client() by returning nothing upon initializing client
59+
See notes in mock_load_expression_data for context.
60+
"""
61+
return

tests/test_ingest.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
"""Integration tests for Ingest Pipeline; isolated tests for observable output
22
33
These tests verify that various matrix file types can be extracted and
4-
transformed, as loaded into (an official emulator of) Firestore
4+
transformed, as expected by code that loads transformed data into Firestore.
55
66
Test doubles are used for test speed and isolation.
77
@@ -15,19 +15,17 @@
1515
pytest
1616
1717
# Run tests with names containing the string 'dense'
18-
pytest -k 'dense'
18+
pytest -ks 'dense'
1919
2020
# Run all tests in a manner that shows any print() statements
21-
python3 test_ingest.py
21+
pytest -s
2222
2323
# Run all tests, using multiple CPUs
2424
# Details: https://pypi.org/project/pytest-xdist/
25-
pytest -n auto
25+
pytest -ns auto
2626
2727
# Run all tests, show code coverage metrics
28-
# For explanation of coverage report, see:
29-
# https://coverage.readthedocs.io/en/v4.5.x/branch.html
30-
coverage run --branch test_ingest.py; coverage report -m --include *scp-ingest-pipeline/ingest*
28+
pytest --cov=../ingest/
3129
3230
"""
3331
import ast

0 commit comments

Comments
 (0)