Fix typos. remove pass statement

Author: knapii-developments

ingest/cell_metadata.py

@@ -84,7 +84,7 @@ def validate_header_for_coordinate_values(self):
         if valid:
             return True
         else:
-            msg = f'Header names can not be coordinate values x, y, or z (case insensitive)'
+            msg = 'Header names can not be coordinate values x, y, or z (case insensitive)'
             self.store_validation_issue('error', 'format', msg)
             return False
 

ingest/clusters.py

@@ -96,7 +96,7 @@ def validate_header_for_coordinate_values(self):
         for coordinate in ('x', 'y'):
             if coordinate not in lower_cased_headers:
                 msg = (
-                    f"Header must have coordinate values 'x' and 'y' (case insensitive)"
+                    "Header must have coordinate values 'x' and 'y' (case insensitive)"
                 )
                 self.store_validation_issue('error', 'format', msg)
                 return False

ingest/ingest_pipeline.py

@@ -406,7 +406,6 @@ def ingest_expression(self) -> int:
     def ingest_cell_metadata(self):
         """Ingests cell metadata files into Firestore."""
         if self.cell_metadata.validate():
-            pass
             self.info_logger.info(
                 f'Cell metadata file format valid', extra=self.extra_log_params
             )

tests/data/metadata_example.txt

@@ -14,4 +14,4 @@ CELL_00011	CLST_C	CLST_C_1	0.638
 CELL_00012	CLST_C	CLST_C_1	8.888
 CELL_00013	CLST_C	CLST_C_1	-2.27
 CELL_00014	CLST_C	CLST_C_2	-2.606
-CELL_00015	CLST_C	CLST_C_2	-9.089z
+CELL_00015	CLST_C	CLST_C_2	-9.089

tests/test_cell_metadata.py

@@ -8,7 +8,7 @@
 class TestCellMetadata(unittest.TestCase):
     def test_validate_header_for_coordinate_values_false(self):
         """Ensures validate_header_for_coordinate_values returns false when
-        coordintate value is in metadata file
+        coordinate value is in metadata file
          """
         cm = CellMetadata(
             '../tests/data/metadata_bad_contains_coordinates.txt',
@@ -21,7 +21,7 @@ def test_validate_header_for_coordinate_values_false(self):
 
     def test_validate_header_for_coordinate_values_true(self):
         """Ensures validate_header_for_coordinate_values returns true when
-        coordintate value is not in metadata file
+        coordinate value is not in metadata file
          """
         cm = CellMetadata(
             '../tests/data/metadata_example.txt',