Resolve all the pedantic lints (#313)

* fix(clippy): allow cast_precision_loss and cast_sign_loss pedantic lints

Signed-off-by: Jérémy Audiger <[email protected]>

* fix(clippy): allow unsafe_derive_deserialize pedantic lint

Signed-off-by: Jérémy Audiger <[email protected]>

* fix(clippy): resolve default_trait_access pedantic lint

Signed-off-by: Jérémy Audiger <[email protected]>

* refactor(cargo): fully enable pedantic lints in codebase

Signed-off-by: Jérémy Audiger <[email protected]>

---------

Signed-off-by: Jérémy Audiger <[email protected]>

Author: jaudiger

Cargo.toml

@@ -14,6 +14,7 @@ resolver = "3"
 [workspace.lints.clippy]
 all = { level = "warn", priority = -1 }
 nursery = { level = "warn", priority = -1 }
+pedantic = { level = "warn", priority = -1 }
 cognitive_complexity = "allow"
 future_not_send = "allow"
 implicit_hasher = "allow"
@@ -24,53 +25,11 @@ struct_excessive_bools = "allow"
 struct_field_names = "allow"
 too_many_lines = "allow"
 allow_attributes = "warn"
-cast_lossless = "warn"
-cast_possible_truncation = "warn"
-cast_possible_wrap = "warn"
-checked_conversions = "warn"
 dbg_macro = "warn"
-explicit_deref_methods = "warn"
-explicit_into_iter_loop = "warn"
-explicit_iter_loop = "warn"
-filter_map_next = "warn"
-flat_map_option = "warn"
-from_iter_instead_of_collect = "warn"
-if_not_else = "warn"
-ignored_unit_patterns = "warn"
-implicit_clone = "warn"
-items_after_statements = "warn"
 large_const_arrays = "warn"
-large_futures = "warn"
-manual_assert = "warn"
-manual_is_variant_and = "warn"
-manual_let_else = "warn"
-map_unwrap_or = "warn"
-match_same_arms = "warn"
-must_use_candidate = "warn"
-needless_continue = "warn"
-needless_for_each = "warn"
-needless_pass_by_value = "warn"
-option_as_ref_cloned = "warn"
 print_stderr = "warn"
 print_stdout = "warn"
-redundant_else = "warn"
-ref_option = "warn"
-ref_option_ref = "warn"
-return_self_not_must_use = "warn"
-semicolon_if_nothing_returned = "warn"
-similar_names = "warn"
-trivially_copy_pass_by_ref = "warn"
-uninlined_format_args = "warn"
-unnecessary_wraps = "warn"
-unnested_or_patterns = "warn"
-unreadable_literal = "warn"
-unused_async = "warn"
-unused_self = "warn"
 unused_trait_names = "warn"
-used_underscore_binding = "warn"
-used_underscore_items = "warn"
-unnecessary_debug_formatting = "warn"
-unnecessary_semicolon = "warn"
 
 [profile.dev]
 debug = "limited"

crates/brioche-core/benches/input.rs

@@ -1,5 +1,6 @@
 use std::collections::HashMap;
 use std::io::Write as _;
+use std::sync::Arc;
 
 use brioche_core::Brioche;
 
@@ -62,7 +63,7 @@ fn bench_input(bencher: divan::Bencher, removal: Removal) {
         .bench_values(|ctx| {
             ctx.runtime.block_on(async {
                 let mut saved_paths = HashMap::default();
-                let meta = Default::default();
+                let meta = Arc::default();
 
                 brioche_core::input::create_input(
                     &ctx.brioche,
@@ -133,7 +134,7 @@ fn bench_input_with_shared_resources(bencher: divan::Bencher, removal: Removal)
         .bench_values(|ctx| {
             ctx.runtime.block_on(async {
                 let mut saved_paths = HashMap::default();
-                let meta = Default::default();
+                let meta = Arc::default();
 
                 brioche_core::input::create_input(
                     &ctx.brioche,
@@ -242,7 +243,7 @@ fn bench_input_with_shared_ancestor_resources(bencher: divan::Bencher, removal:
         })
         .bench_values(|ctx| {
             ctx.runtime.block_on(async {
-                let meta = Default::default();
+                let meta = Arc::default();
                 brioche_core::input::create_input(
                     &ctx.brioche,
                     brioche_core::input::InputOptions {

crates/brioche-core/src/download.rs

@@ -103,7 +103,10 @@ pub async fn fetch_git_commit_for_ref(
             .with_context(|| format!("failed to parse git repository URL: {repository}"))?;
         move || {
             // Connect to the repository by URL
-            let transport = gix::protocol::transport::connect(repository, Default::default());
+            let transport = gix::protocol::transport::connect(
+                repository,
+                gix::protocol::transport::client::connect::Options::default(),
+            );
             let mut transport = match transport {
                 Ok(transport) => transport,
                 Err(error) => {

crates/brioche-core/src/input.rs

@@ -97,7 +97,7 @@ pub async fn create_input(
                         &mut blob_permit,
                         &path,
                         super::blob::SaveBlobOptions::default().remove_input(remove_blob),
-                        &mut Default::default(),
+                        &mut Vec::default(),
                     )
                     .await?;
 

crates/brioche-core/src/project/load.rs

@@ -14,7 +14,7 @@ use tracing::Instrument as _;
 use crate::{
     Brioche,
     project::{DependencyRef, ProjectEntry, Workspace, WorkspaceHash},
-    recipe::Artifact,
+    recipe::{Artifact, Directory},
 };
 
 use super::{
@@ -941,7 +941,7 @@ async fn resolve_static(
                 project_root.display(),
             );
             let mut saved_paths = HashMap::default();
-            let meta = Default::default();
+            let meta = Arc::default();
 
             let artifact = crate::input::create_input(
                 brioche,
@@ -1023,7 +1023,7 @@ async fn resolve_static(
             let artifacts = futures::stream::iter(paths)
                 .then(|(full_path, relative_path)| async move {
                     let mut saved_paths = HashMap::default();
-                    let meta = Default::default();
+                    let meta = Arc::default();
 
                     let artifact = crate::input::create_input(
                         brioche,
@@ -1125,7 +1125,7 @@ async fn resolve_static(
                 let download_artifact = crate::recipe::Artifact::File(crate::recipe::File {
                     content_blob: blob_hash,
                     executable: false,
-                    resources: Default::default(),
+                    resources: Directory::default(),
                 });
 
                 let download_recipe_json = serde_json::to_string(&download_recipe)

crates/brioche-core/src/recipe.rs

@@ -674,6 +674,7 @@ pub struct File {
     pub resources: Directory,
 }
 
+#[expect(clippy::unsafe_derive_deserialize)]
 #[serde_with::serde_as]
 #[derive(Debug, Default, Clone, PartialEq, Eq, Hash, serde::Serialize, serde::Deserialize)]
 #[serde(rename_all = "camelCase")]

crates/brioche-core/src/reporter/console.rs

@@ -652,7 +652,11 @@ impl superconsole::Component for JobsComponent {
 struct JobComponent<'a>(JobId, &'a Job);
 
 impl superconsole::Component for JobComponent<'_> {
-    #[expect(clippy::cast_possible_truncation)]
+    #[expect(
+        clippy::cast_possible_truncation,
+        clippy::cast_precision_loss,
+        clippy::cast_sign_loss
+    )]
     fn draw_unchecked(
         &self,
         dimensions: superconsole::Dimensions,
@@ -1022,7 +1026,11 @@ fn indicator_span(kind: IndicatorKind) -> superconsole::Span {
     }
 }
 
-#[expect(clippy::cast_possible_truncation)]
+#[expect(
+    clippy::cast_possible_truncation,
+    clippy::cast_precision_loss,
+    clippy::cast_sign_loss
+)]
 fn progress_bar_spans(
     interior: &str,
     width: usize,

crates/brioche-core/src/reporter/job.rs

@@ -103,7 +103,7 @@ impl Job {
                 finished_at: None,
             },
             NewJob::Process { status } => Self::Process {
-                packet_queue: Default::default(),
+                packet_queue: DebugIgnore::default(),
                 status,
             },
             NewJob::CacheFetch {

crates/brioche-core/src/script/evaluate.rs

@@ -127,7 +127,7 @@ async fn evaluate_with_deno(
 
             // Resolve the export if it's a promise
             let resolved_result_fut = js_runtime.resolve(result);
-            let resolved_result = js_runtime.with_event_loop_promise(resolved_result_fut, Default::default()).await?;
+            let resolved_result = js_runtime.with_event_loop_promise(resolved_result_fut, deno_core::PollEventLoopOptions::default()).await?;
 
             // Call the `briocheSerialize` function on the result
             let serialized_result = {
@@ -164,7 +164,7 @@ async fn evaluate_with_deno(
 
             // Resolve the result of `briocheSerialize` if it's a promise
             let serialized_resolved_result_fut = js_runtime.resolve(serialized_result);
-            let serialized_resolved_result = js_runtime.with_event_loop_promise(serialized_resolved_result_fut, Default::default()).await?;
+            let serialized_resolved_result = js_runtime.with_event_loop_promise(serialized_resolved_result_fut, deno_core::PollEventLoopOptions::default()).await?;
 
             let mut js_scope = js_runtime.handle_scope();
 

crates/brioche-core/src/script/lsp.rs

@@ -12,11 +12,11 @@ use tower_lsp::lsp_types::{
     DocumentDiagnosticReport, DocumentDiagnosticReportResult, DocumentFormattingParams,
     DocumentHighlight, DocumentHighlightParams, FullDocumentDiagnosticReport, GotoDefinitionParams,
     GotoDefinitionResponse, Hover, HoverParams, HoverProviderCapability, InitializeParams,
-    InitializeResult, InitializedParams, Location, MessageType, OneOf, Position,
-    PrepareRenameResponse, Range, ReferenceParams, RelatedFullDocumentDiagnosticReport,
+    InitializeResult, InitializedParams, Location, MessageType, OneOf, PartialResultParams,
+    Position, PrepareRenameResponse, Range, ReferenceParams, RelatedFullDocumentDiagnosticReport,
     RenameOptions, RenameParams, ServerCapabilities, TextDocumentIdentifier,
     TextDocumentPositionParams, TextDocumentSyncCapability, TextDocumentSyncKind, TextEdit,
-    WorkspaceEdit,
+    WorkDoneProgressOptions, WorkDoneProgressParams, WorkspaceEdit,
 };
 use tower_lsp::{Client, LanguageServer};
 use tracing::Instrument as _;
@@ -97,9 +97,9 @@ impl BriocheLspServer {
             .send(JsLspMessage::Diagnostic(DocumentDiagnosticParams {
                 identifier: None,
                 previous_result_id: None,
-                partial_result_params: Default::default(),
+                partial_result_params: PartialResultParams::default(),
                 text_document,
-                work_done_progress_params: Default::default(),
+                work_done_progress_params: WorkDoneProgressParams::default(),
             }))
             .await?;
         Ok(diagnostics)
@@ -126,7 +126,7 @@ impl LanguageServer for BriocheLspServer {
                 document_highlight_provider: Some(OneOf::Left(true)),
                 rename_provider: Some(OneOf::Right(RenameOptions {
                     prepare_provider: Some(true),
-                    work_done_progress_options: Default::default(),
+                    work_done_progress_options: WorkDoneProgressOptions::default(),
                 })),
                 document_formatting_provider: Some(OneOf::Left(true)),
                 ..Default::default()