Skip to content

Conversation

@jaudiger
Copy link
Contributor

Add a new package libvpx: Codec library implementing VP8 and VP9 encoders and decoders.

Running brioche-run
{
  "name": "libvpx",
  "version": "1.15.2",
  "repository": "https://github.com/webmproject/libvpx"
}

⏵ Task `Run package live-update` finished successfully
Build finished, completed 1 job in 1.84s
Result: 99c3991aee295966e9d9d07ce396bab26c978a64eff6ede16759a8430b2ba13c

⏵ Task `Run package test` finished successfully

Signed-off-by: Jérémy Audiger <[email protected]>
@jaudiger jaudiger requested a review from kylewlacy October 14, 2025 06:23
@jaudiger jaudiger self-assigned this Oct 14, 2025
@kylewlacy kylewlacy added this pull request to the merge queue Oct 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2025
@jaudiger
Copy link
Contributor Author

I didn't test it locally in an x86_64 environment, since I'm now using an aarch64 environment 😅 So it worked with aarch64, but not x86_64:

[0.00s] [spawned process with pid 12289, preparation took 0.00s]
[0.03s]   disabling examples
[0.03s]   disabling unit_tests
[0.03s]   enabling pic
[0.03s]   enabling runtime_cpu_detect
[0.03s]   enabling shared
[0.04s]   enabling vp9_highbitdepth
[0.04s]   enabling vp8_encoder
[0.04s]   enabling vp8_decoder
[0.04s]   enabling vp9_encoder
[0.04s]   enabling vp9_decoder
[0.04s] Configuring for target 'x86_64-linux-gcc'
[0.04s]   enabling x86_64
[0.08s]   enabling mmx
[0.09s]   enabling sse
[0.10s]   enabling sse2
[0.11s]   enabling sse3
[0.11s]   enabling ssse3
[0.12s]   enabling sse4_1
[0.13s]   enabling avx
[0.14s]   enabling avx2
[0.15s]   enabling avx512
[0.41s] Neither yasm nor nasm have been found. See the prerequisites section in the README for more info.
[0.41s]
[0.41s] Configuration failed. This could reflect a misconfiguration of your
[0.41s] toolchains, improper options selected, or another problem. If you
[0.41s] don't see any useful error messages above, the next step is to look
[0.41s] at the configure error log file (config.log) to determine what
[0.41s] configure was trying to do when it died.
[0.42s] [process exited with code 1]

From the README of libvpx:

  1. Prerequisites

    * All x86 targets require the NASM[0] or Yasm[1] assembler be installed[2].

So let's add NASM, and not Yasm (since it's unmaintained), and see if it resolves the issue by just adding the NASM binary to $PATH

@jaudiger jaudiger requested a review from kylewlacy October 15, 2025 16:24
@jaudiger jaudiger mentioned this pull request Oct 15, 2025
Copy link
Member

@kylewlacy kylewlacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested this time beforehand on x86-64, looks like everything's working now!

@kylewlacy kylewlacy added this pull request to the merge queue Oct 16, 2025
Merged via the queue into brioche-dev:main with commit e3d4712 Oct 16, 2025
3 checks passed
@jaudiger jaudiger deleted the add-libvpx branch October 16, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants