Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify live reload SSE endpoint after Puma bug is fixed #950

Open
ayushn21 opened this issue Dec 4, 2024 · 0 comments
Open

Simplify live reload SSE endpoint after Puma bug is fixed #950

ayushn21 opened this issue Dec 4, 2024 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ayushn21
Copy link
Member

ayushn21 commented Dec 4, 2024

While pairing with @ioquatix, we looked at the live reload code in Bridgetown to try and make it work with both Falcon and Puma.

Currently we're spawning a background thread to hold the connection, which is at best a hack, and at worst, wrong. We need to do this because Ctrl+C doesn't kill Puma without it. This turns out to be a bug in Puma itself. We've filed an issue here: puma/puma#3569.

After this is fixed, we should be able to remove the background thread from the SSE endpoint without any issues.

@ayushn21 ayushn21 added the bug Something isn't working label Dec 4, 2024
@ayushn21 ayushn21 self-assigned this Dec 4, 2024
@jaredcwhite jaredcwhite added this to the 2.1 milestone Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants