Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of "filters" used as helpers in Ruby templates #929

Open
jaredcwhite opened this issue Oct 21, 2024 · 0 comments
Open
Assignees
Milestone

Comments

@jaredcwhite
Copy link
Member

jaredcwhite commented Oct 21, 2024

Currently we're including Bridgetown::Filters in the Bridgetown::RubyTemplateView::Helpers object. That brings over a whole bunch of methods which really only seem useful (and not always idiomatic Ruby) in a Liquid template. It would be advantageous to determine which filter methods are Liquid-specific and which are suitable for Ruby templates, and include only the suitable ones. This likely means we'll stop including Bridgetown::Filters directly and rather include some subset module, along with Liquid-only stuff getting moved elsewhere.

@jaredcwhite jaredcwhite added this to the 2.0 milestone Oct 21, 2024
@jaredcwhite jaredcwhite self-assigned this Oct 21, 2024
@jaredcwhite jaredcwhite removed this from the 2.0 milestone Nov 9, 2024
@jaredcwhite jaredcwhite added this to the 2.1 milestone Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@jaredcwhite and others