Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for cyclical node graphs #94

Open
brianchirls opened this issue Jun 15, 2015 · 1 comment
Open

Allow for cyclical node graphs #94

brianchirls opened this issue Jun 15, 2015 · 1 comment
Labels
Feature

Comments

@brianchirls
Copy link
Owner

Requested by @positlabs in #93, for creating feedback loops and for feeding output back into nodes as sort of an "undo" function.

The algorithm for tracing back through the network from the target nodes will mark each node as rendered for the current pass, to prevent infinite loops. As a result, looped inputs will be one frame behind the current render pass. (I believe puredata works similarly.)
@brianchirls
Copy link
Owner Author

Will need to check for loops in all method calls that signal forward or backward:

  • render
  • resize
  • setReady?
  • setUnready?
  • setDirty?

setDirty doesn't seem to be a problem since it already checks its state. Same for ready/unready.

brianchirls added a commit that referenced this issue Jun 25, 2015
@brianchirls
Start work enabling cyclical graphs #94
4560cb3 
Still needs work
- make sure ready and dirty state are accurate
- when an effect has itself as a source, need separate source and destination textures (ping pong)
- more unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brianchirls