From 51ebea1f687d517f1aa555ac269ffc6d1e3763ec Mon Sep 17 00:00:00 2001
From: Brian Chirls <brian@chirls.com>
Date: Thu, 29 Oct 2015 16:20:45 -0400
Subject: [PATCH] Fix: Channels effect crashes when setting alphaSource when
 source is undefined (#109)

---
 effects/seriously.channels.js |   5 +++
 test/media/tiny.png           | Bin 0 -> 169 bytes
 test/seriously.unit.js        |  64 ++++++++++++++++++++++++++++++++++
 3 files changed, 69 insertions(+)
 create mode 100644 test/media/tiny.png

diff --git a/effects/seriously.channels.js b/effects/seriously.channels.js
index ca9d52f..6dd1e24 100644
--- a/effects/seriously.channels.js
+++ b/effects/seriously.channels.js
@@ -95,6 +95,11 @@
 				s = inputs[name];
 				if (!s) {
 					s = me.sources[name] = inputs[name] = inputs.source;
+
+					if (!s) {
+						//no main source to fall back to
+						return;
+					}
 				}
 
 				j = sources.indexOf(s);
diff --git a/test/media/tiny.png b/test/media/tiny.png
new file mode 100644
index 0000000000000000000000000000000000000000..b5daf2370284e065b88aa796bcbfd4a35cb86bc5
GIT binary patch
literal 169
zcmeAS@N?(olHy`uVBq!ia0vp^4j|0I1SD0tpLGH$&H|6fVj#^3#{Q~Dt^pa*o-U3d
z6?5L6-^j_JAi%OA+LiktCu?a%`i38R6IdtB4qcTxy{iE$I8go|Wy-6WOIfgkeYUS>
WzUX-U+cyhn4TGnvpUXO@geCxTG%<?+

literal 0
HcmV?d00001

diff --git a/test/seriously.unit.js b/test/seriously.unit.js
index c06f586..93bb5a1 100644
--- a/test/seriously.unit.js
+++ b/test/seriously.unit.js
@@ -3134,4 +3134,68 @@
 			start();
 		});
 	});
+
+	asyncTest('Channels', 5, function () {
+		require([
+			'seriously',
+			'effects/seriously.channels',
+			'sources/seriously.array'
+		], function (Seriously) {
+			var seriously,
+				effect,
+				target,
+				canvas,
+				pixels,
+				error,
+				incompatible,
+				array = [
+					255, 255, 255, 255,
+					255, 0, 0, 255,
+					0, 255, 0, 128,
+					0, 0, 255, 0
+				],
+				arraySource,
+				img,
+				imgSource,
+				expected;
+
+			incompatible = Seriously.incompatible();
+
+			seriously = new Seriously();
+			arraySource = seriously.source(array, {
+				width: 2,
+				height: 2
+			});
+
+			canvas = document.createElement('canvas');
+			canvas.width = canvas.height = 1;
+			target = seriously.target(canvas);
+
+			img = document.createElement('img');
+			img.src = 'media/tiny.png';
+			imgSource = seriously.source(img);
+
+			effect = seriously.effect('channels');
+			ok(effect, 'Channels effect successfully created');
+
+			effect.alphaSource = arraySource;
+			ok(true, 'Set alphaSource without having a main "source" input set (issue #109)');
+
+			effect.source = imgSource;
+			equal(effect.redSource, imgSource, 'Unset channel sources fall back to main "source" input');
+
+			effect.source = arraySource;
+			equal(effect.source, arraySource, 'Set main "source" a second time (issue #109)');
+			equal(effect.redSource, imgSource, 'Unset channel sources remain set to original main "source" even after it changes.');
+
+			target.source = effect;
+
+			//todo: render and readPixels to test accurate render results
+
+			seriously.destroy();
+			Seriously.removePlugin('channels');
+
+			start();
+		});
+	});
 }());