Merge pull request #23 from brevdev/devin/1754781803-separate-lambdalabs-credentials

Separate Lambda Labs credential logic into credential.go

Author: theFong

internal/lambdalabs/v1/client.go

@@ -2,8 +2,6 @@ package v1
 
 import (
 	"context"
-	"crypto/sha256"
-	"fmt"
 	"net/http"
 	"time"
 
@@ -12,51 +10,6 @@ import (
 	"github.com/cenkalti/backoff/v4"
 )
 
-// LambdaLabsCredential implements the CloudCredential interface for Lambda Labs
-type LambdaLabsCredential struct {
-	RefID  string
-	APIKey string
-}
-
-var _ v1.CloudCredential = &LambdaLabsCredential{}
-
-// NewLambdaLabsCredential creates a new Lambda Labs credential
-func NewLambdaLabsCredential(refID, apiKey string) *LambdaLabsCredential {
-	return &LambdaLabsCredential{
-		RefID:  refID,
-		APIKey: apiKey,
-	}
-}
-
-// GetReferenceID returns the reference ID for this credential
-func (c *LambdaLabsCredential) GetReferenceID() string {
-	return c.RefID
-}
-
-// GetAPIType returns the API type for Lambda Labs
-func (c *LambdaLabsCredential) GetAPIType() v1.APIType {
-	return v1.APITypeGlobal
-}
-
-const CloudProviderID = "lambda-labs"
-
-const DefaultRegion string = "us-west-1"
-
-// GetCloudProviderID returns the cloud provider ID for Lambda Labs
-func (c *LambdaLabsCredential) GetCloudProviderID() v1.CloudProviderID {
-	return CloudProviderID
-}
-
-// GetTenantID returns the tenant ID for Lambda Labs
-func (c *LambdaLabsCredential) GetTenantID() (string, error) {
-	return fmt.Sprintf("lambdalabs-%x", sha256.Sum256([]byte(c.APIKey))), nil
-}
-
-// MakeClient creates a new Lambda Labs client from this credential
-func (c *LambdaLabsCredential) MakeClient(_ context.Context, _ string) (v1.CloudClient, error) {
-	return NewLambdaLabsClient(c.RefID, c.APIKey), nil
-}
-
 // LambdaLabsClient implements the CloudClient interface for Lambda Labs
 // It embeds NotImplCloudClient to handle unsupported features
 type LambdaLabsClient struct {
@@ -91,7 +44,7 @@ func (c *LambdaLabsClient) GetAPIType() v1.APIType {
 
 // GetCloudProviderID returns the cloud provider ID for Lambda Labs
 func (c *LambdaLabsClient) GetCloudProviderID() v1.CloudProviderID {
-	return "lambdalabs"
+	return CloudProviderID
 }
 
 // MakeClient creates a new client instance

internal/lambdalabs/v1/client_test.go

@@ -18,7 +18,7 @@ func TestLambdaLabsClient_GetAPIType(t *testing.T) {
 
 func TestLambdaLabsClient_GetCloudProviderID(t *testing.T) {
 	client := &LambdaLabsClient{}
-	assert.Equal(t, v1.CloudProviderID("lambdalabs"), client.GetCloudProviderID())
+	assert.Equal(t, v1.CloudProviderID(CloudProviderID), client.GetCloudProviderID())
 }
 
 func TestLambdaLabsClient_MakeClient(t *testing.T) {

internal/lambdalabs/v1/credential.go

@@ -0,0 +1,54 @@
+package v1
+
+import (
+	"context"
+	"crypto/sha256"
+	"fmt"
+
+	v1 "github.com/brevdev/cloud/pkg/v1"
+)
+
+const CloudProviderID = "lambda-labs"
+
+const DefaultRegion string = "us-west-1"
+
+// LambdaLabsCredential implements the CloudCredential interface for Lambda Labs
+type LambdaLabsCredential struct {
+	RefID  string
+	APIKey string
+}
+
+var _ v1.CloudCredential = &LambdaLabsCredential{}
+
+// NewLambdaLabsCredential creates a new Lambda Labs credential
+func NewLambdaLabsCredential(refID, apiKey string) *LambdaLabsCredential {
+	return &LambdaLabsCredential{
+		RefID:  refID,
+		APIKey: apiKey,
+	}
+}
+
+// GetReferenceID returns the reference ID for this credential
+func (c *LambdaLabsCredential) GetReferenceID() string {
+	return c.RefID
+}
+
+// GetAPIType returns the API type for Lambda Labs
+func (c *LambdaLabsCredential) GetAPIType() v1.APIType {
+	return v1.APITypeGlobal
+}
+
+// GetCloudProviderID returns the cloud provider ID for Lambda Labs
+func (c *LambdaLabsCredential) GetCloudProviderID() v1.CloudProviderID {
+	return CloudProviderID
+}
+
+// GetTenantID returns the tenant ID for Lambda Labs
+func (c *LambdaLabsCredential) GetTenantID() (string, error) {
+	return fmt.Sprintf("lambdalabs-%x", sha256.Sum256([]byte(c.APIKey))), nil
+}
+
+// MakeClient creates a new Lambda Labs client from this credential
+func (c *LambdaLabsCredential) MakeClient(_ context.Context, _ string) (v1.CloudClient, error) {
+	return NewLambdaLabsClient(c.RefID, c.APIKey), nil
+}