include gpu memory

Author: drewmalin

v1/instancetype.go

@@ -114,13 +114,14 @@ func MakeGenericInstanceTypeIDFromInstance(instance Instance) InstanceTypeID {
 }
 
 type GPU struct {
-	Count          int32
-	Memory         units.Base2Bytes
-	MemoryDetails  string // "", "HBM", "GDDR", "DDR", etc.
-	NetworkDetails string // "PCIe", "SXM4", "SXM5", etc.
-	Manufacturer   Manufacturer
-	Name           string
-	Type           string
+	Count           int32
+	Memory          units.Base2Bytes // TODO: deprecate in favor of MemoryByteValue
+	MemoryByteValue ByteValue
+	MemoryDetails   string // "", "HBM", "GDDR", "DDR", etc.
+	NetworkDetails  string // "PCIe", "SXM4", "SXM5", etc.
+	Manufacturer    Manufacturer
+	Name            string
+	Type            string
 }
 
 type InstanceTypeQuota struct {

v1/providers/lambdalabs/instancetype.go

@@ -128,6 +128,7 @@ func parseGPUFromDescription(input string) (v1.GPU, error) {
 	memoryStr := memoryMatch[1]
 	memoryGiB, _ := strconv.Atoi(memoryStr)
 	gpu.Memory = units.GiB * units.Base2Bytes(memoryGiB)
+	gpu.MemoryByteValue = v1.NewByteValue(int32(memoryGiB), v1.Gibibyte)
 
 	// Extract the network details
 	networkRegex := regexp.MustCompile(`(\w+\s?)+\)`)

v1/providers/launchpad/instancetype.go

@@ -259,12 +259,13 @@ func launchpadGpusToGpus(lpGpus []openapi.InstanceTypeGpu) []v1.GPU {
 	gpus := make([]v1.GPU, len(lpGpus))
 	for i, gp := range lpGpus {
 		gpus[i] = v1.GPU{
-			Name:           strings.ToUpper(gp.Family),
-			Manufacturer:   v1.GetManufacturer(gp.Manufacturer),
-			Count:          gp.Count,
-			Memory:         gbToBytes(gp.MemoryGb),
-			NetworkDetails: string(gp.InterconnectionType),
-			Type:           strings.ToUpper(gp.Model),
+			Name:            strings.ToUpper(gp.Family),
+			Manufacturer:    v1.GetManufacturer(gp.Manufacturer),
+			Count:           gp.Count,
+			Memory:          gbToBytes(gp.MemoryGb),
+			MemoryByteValue: v1.NewByteValue(gp.MemoryGb, v1.Gigabyte),
+			NetworkDetails:  string(gp.InterconnectionType),
+			Type:            strings.ToUpper(gp.Model),
 		}
 	}
 	return gpus

v1/providers/shadeform/instancetype.go

@@ -232,13 +232,14 @@ func (c *ShadeformClient) convertShadeformInstanceTypeToV1InstanceType(shadeform
 			MemoryByteValue: v1.NewByteValue(shadeformInstanceType.Configuration.MemoryInGb, v1.Gigabyte),
 			SupportedGPUs: []v1.GPU{
 				{
-					Count:          shadeformInstanceType.Configuration.NumGpus,
-					Memory:         units.Base2Bytes(shadeformInstanceType.Configuration.VramPerGpuInGb) * units.GiB,
-					MemoryDetails:  "",
-					NetworkDetails: shadeformInstanceType.Configuration.Interconnect,
-					Manufacturer:   gpuManufacturer,
-					Name:           gpuName,
-					Type:           shadeformInstanceType.Configuration.GpuType,
+					Count:           shadeformInstanceType.Configuration.NumGpus,
+					Memory:          units.Base2Bytes(shadeformInstanceType.Configuration.VramPerGpuInGb) * units.GiB,
+					MemoryByteValue: v1.NewByteValue(shadeformInstanceType.Configuration.VramPerGpuInGb, v1.Gigabyte),
+					MemoryDetails:   "",
+					NetworkDetails:  shadeformInstanceType.Configuration.Interconnect,
+					Manufacturer:    gpuManufacturer,
+					Name:            gpuName,
+					Type:            shadeformInstanceType.Configuration.GpuType,
 				},
 			},
 			SupportedStorage: []v1.Storage{ // TODO: add storage (look in configuration)