Skip to content

Commit 9450d25

Browse files
committed
Fix(BREV-2215): missing refid for shadeform
1 parent ddfb4b1 commit 9450d25

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

v1/providers/shadeform/instance.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ func (c *ShadeformClient) ListInstances(ctx context.Context, _ v1.ListInstancesA
253253
for _, instance := range resp.Instances {
254254
singleInstance, err := c.convertShadeformInstanceToV1Instance(instance)
255255
if err != nil {
256-
return nil, errors.WrapAndTrace(err)
256+
continue
257257
}
258258
instances = append(instances, *singleInstance)
259259
}
@@ -357,13 +357,13 @@ func (c *ShadeformClient) convertShadeformInstanceToV1Instance(shadeformInstance
357357

358358
refID, found := tags[refIDTagName]
359359
if !found {
360-
return nil, errors.WrapAndTrace(errors.New("could not find refID tag"))
360+
return nil, fmt.Errorf("instance missing refID tag: instanceID=%s, instanceName=%s", shadeformInstance.Id, shadeformInstance.Name)
361361
}
362362
delete(tags, refIDTagName)
363363

364364
cloudCredRefID, found := tags[cloudCredRefIDTagName]
365365
if !found {
366-
return nil, errors.WrapAndTrace(errors.New("could not find cloudCredRefID tag"))
366+
return nil, fmt.Errorf("instance missing cloudCredRefID tag: instanceID=%s, instanceName=%s", shadeformInstance.Id, shadeformInstance.Name)
367367
}
368368
delete(tags, cloudCredRefIDTagName)
369369

0 commit comments

Comments
 (0)