tests

Author: drewmalin

v1/providers/nebius/image.go

@@ -202,6 +202,13 @@ func getImageDescription(image *compute.Image) string {
 	return ""
 }
 
+const (
+	ArchitectureX86_64  = "x86_64"
+	ArchitectureArm64   = "arm64"
+	ArchitectureAMD64   = "amd64"
+	ArchitectureAArch64 = "aarch64"
+)
+
 // extractArchitecture extracts architecture information from image metadata
 func extractArchitecture(image *compute.Image) string {
 	// Check labels for architecture info
@@ -217,16 +224,15 @@ func extractArchitecture(image *compute.Image) string {
 	// Infer from image name
 	if image.Metadata != nil {
 		name := strings.ToLower(image.Metadata.Name)
-		if strings.Contains(name, "arm64") || strings.Contains(name, "aarch64") {
-			return "arm64"
+		if strings.Contains(name, ArchitectureArm64) || strings.Contains(name, ArchitectureAArch64) {
+			return ArchitectureArm64
 		}
-		if strings.Contains(name, "x86_64") || strings.Contains(name, "amd64") {
-			//nolint:goconst // Architecture string used in detection and returned as default
-			return "x86_64"
+		if strings.Contains(name, ArchitectureX86_64) || strings.Contains(name, ArchitectureAMD64) {
+			return ArchitectureX86_64
 		}
 	}
 
-	return "x86_64"
+	return ArchitectureX86_64
 }
 
 // filterImagesByArchitectures filters images by multiple architectures

v1/providers/nebius/instancetype.go

@@ -29,7 +29,13 @@ func (c *NebiusClient) GetInstanceTypes(ctx context.Context, args v1.GetInstance
 	// Default behavior: check ALL regions to show all available quota
 	var locations []v1.Location
 
-	if len(args.Locations) > 0 && !args.Locations.IsAll() {
+	if args.Locations.IsAll() { //nolint:gocritic // prefer if statement over switch statement
+		allLocations, err := c.GetLocations(ctx, v1.GetLocationsArgs{})
+		if err != nil {
+			return nil, errors.WrapAndTrace(err)
+		}
+		locations = allLocations
+	} else if len(args.Locations) > 0 {
 		// User requested specific locations - filter to those
 		allLocations, err := c.GetLocations(ctx, v1.GetLocationsArgs{})
 		if err == nil {
@@ -48,15 +54,8 @@ func (c *NebiusClient) GetInstanceTypes(ctx context.Context, args v1.GetInstance
 			locations = []v1.Location{{Name: c.location}}
 		}
 	} else {
-		// Default behavior: enumerate ALL regions for quota-aware discovery
-		// This shows users all instance types they have quota for, regardless of region
-		allLocations, err := c.GetLocations(ctx, v1.GetLocationsArgs{})
-		if err == nil {
-			locations = allLocations
-		} else {
-			// Fallback to client's configured location if we can't get all locations
-			locations = []v1.Location{{Name: c.location}}
-		}
+		// Fallback to client's configured location if we can't get all locations
+		locations = []v1.Location{{Name: c.location}}
 	}
 
 	// Get quota information for all regions